From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DEC3FA372A for ; Thu, 17 Oct 2019 22:14:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 67E1A21D7D for ; Thu, 17 Oct 2019 22:14:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="BM/8z0kc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2503716AbfJQWOx (ORCPT ); Thu, 17 Oct 2019 18:14:53 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:51630 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2438047AbfJQWOw (ORCPT ); Thu, 17 Oct 2019 18:14:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=O32NFV5tBKYp86Cbah2xdrWQDoKTQV/dczaLU0XSPeQ=; b=BM/8z0kco4xKU14sNfH6so6wyB ffIUC/2Add86PIU0J0DUgUFkuMREHGWll8g3BukppU7P24cj/1iPSY+Cg2l0FyGG6aGTPQQu+y+OX QfUyyTcXPcL6idnD6SeCF1vvMeVPKDz/0ojL/hqmJjpMu4V8dYtjo2r8X3j6/KlVpheY=; Received: from andrew by vps0.lunn.ch with local (Exim 4.92.2) (envelope-from ) id 1iLE2j-0006rG-Dg; Fri, 18 Oct 2019 00:14:49 +0200 Date: Fri, 18 Oct 2019 00:14:49 +0200 From: Andrew Lunn To: Florian Fainelli Cc: netdev@vger.kernel.org, "David S. Miller" , open list , hkallweit1@gmail.com, bcm-kernel-feedback-list@broadcom.com, olteanv@gmail.com, rmk+kernel@armlinux.org.uk, cphealy@gmail.com, Jose Abreu Subject: Re: [PATCH net-next v2 2/2] net: phy: Add ability to debug RGMII connections Message-ID: <20191017221449.GC24810@lunn.ch> References: <20191017214453.18934-1-f.fainelli@gmail.com> <20191017214453.18934-3-f.fainelli@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191017214453.18934-3-f.fainelli@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > +#ifdef CONFIG_PHY_RGMII_DEBUG > +int phy_rgmii_debug_probe(struct phy_device *phydev); > +#else > +static inline int phy_rgmii_debug_probe(struct phy_device *phydev) > +{ > + return -EOPNOTSUPP; > +} > +#endif Hi Florian Jose wanted to make use of this in his self test code for stmmac. I think to make this more user friendly in that setup, it would be good to return the phy_mode which works, if only one works. The MAC driver can then compare the what it thinks the mode should be to what actually works, and report a test failure if they differ. Andrew