From: David Miller <davem@davemloft.net>
To: edumazet@google.com
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com, Thomas.Bartschies@cvk.de
Subject: Re: [PATCH net] net: ensure correct skb->tstamp in various fragmenters
Date: Fri, 18 Oct 2019 13:03:32 -0400 (EDT) [thread overview]
Message-ID: <20191018.130332.850928941409040390.davem@davemloft.net> (raw)
In-Reply-To: <20191017010056.58021-1-edumazet@google.com>
From: Eric Dumazet <edumazet@google.com>
Date: Wed, 16 Oct 2019 18:00:56 -0700
> Thomas found that some forwarded packets would be stuck
> in FQ packet scheduler because their skb->tstamp contained
> timestamps far in the future.
>
> We thought we addressed this point in commit 8203e2d844d3
> ("net: clear skb->tstamp in forwarding paths") but there
> is still an issue when/if a packet needs to be fragmented.
>
> In order to meet EDT requirements, we have to make sure all
> fragments get the original skb->tstamp.
>
> Note that this original skb->tstamp should be zero in
> forwarding path, but might have a non zero value in
> output path if user decided so.
>
> Fixes: fb420d5d91c1 ("tcp/fq: move back to CLOCK_MONOTONIC")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reported-by: Thomas Bartschies <Thomas.Bartschies@cvk.de>
Applied and queued up for -stable, thanks Eric.
prev parent reply other threads:[~2019-10-18 17:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 1:00 [PATCH net] net: ensure correct skb->tstamp in various fragmenters Eric Dumazet
2019-10-18 17:03 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191018.130332.850928941409040390.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Thomas.Bartschies@cvk.de \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).