From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D46ACA9EA0 for ; Fri, 18 Oct 2019 17:22:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 49F2B21897 for ; Fri, 18 Oct 2019 17:22:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2410593AbfJRRW6 (ORCPT ); Fri, 18 Oct 2019 13:22:58 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:55318 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405964AbfJRRW5 (ORCPT ); Fri, 18 Oct 2019 13:22:57 -0400 Received: from localhost (unknown [IPv6:2603:3023:50c:85e1:5314:1b70:2a53:887e]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 3029911F5F50E; Fri, 18 Oct 2019 10:22:57 -0700 (PDT) Date: Fri, 18 Oct 2019 13:22:56 -0400 (EDT) Message-Id: <20191018.132256.1969438286879618581.davem@davemloft.net> To: andrew@lunn.ch Cc: netdev@vger.kernel.org, dwagner@suse.de, wahrenst@gmx.net Subject: Re: [PATCH net] net: usb: lan78xx: Connect PHY before registering MAC From: David Miller In-Reply-To: <20191017192926.24232-1-andrew@lunn.ch> References: <20191017192926.24232-1-andrew@lunn.ch> X-Mailer: Mew version 6.8 on Emacs 26.2 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 18 Oct 2019 10:22:57 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Andrew Lunn Date: Thu, 17 Oct 2019 21:29:26 +0200 > As soon as the netdev is registers, the kernel can start using the > interface. If the driver connects the MAC to the PHY after the netdev > is registered, there is a race condition where the interface can be > opened without having the PHY connected. > > Change the order to close this race condition. > > Fixes: 92571a1aae40 ("lan78xx: Connect phy early") > Reported-by: Daniel Wagner > Signed-off-by: Andrew Lunn Applied and queued up for -stable, thanks.