From: Wei Liu <wei.liu@kernel.org>
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Wei Liu <wei.liu@kernel.org>,
Paul Durrant <paul@xen.org>,
"David S. Miller" <davem@davemloft.net>,
stable@vger.kernel.org
Subject: Re: [PATCH] xen/netback: fix error path of xenvif_connect_data()
Date: Fri, 18 Oct 2019 10:10:26 +0100 [thread overview]
Message-ID: <20191018091026.fu4gykxx2mmbdfk3@debian> (raw)
In-Reply-To: <20191018074549.4778-1-jgross@suse.com>
On Fri, Oct 18, 2019 at 09:45:49AM +0200, Juergen Gross wrote:
> xenvif_connect_data() calls module_put() in case of error. This is
> wrong as there is no related module_get().
>
> Remove the superfluous module_put().
>
> Fixes: 279f438e36c0a7 ("xen-netback: Don't destroy the netdev until the vif is shut down")
> Cc: <stable@vger.kernel.org> # 3.12
> Signed-off-by: Juergen Gross <jgross@suse.com>
> Reviewed-by: Paul Durrant <paul@xen.org>
Reviewed-by: Wei Liu <wei.liu@kernel.org>
> ---
> drivers/net/xen-netback/interface.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c
> index 240f762b3749..103ed00775eb 100644
> --- a/drivers/net/xen-netback/interface.c
> +++ b/drivers/net/xen-netback/interface.c
> @@ -719,7 +719,6 @@ int xenvif_connect_data(struct xenvif_queue *queue,
> xenvif_unmap_frontend_data_rings(queue);
> netif_napi_del(&queue->napi);
> err:
> - module_put(THIS_MODULE);
> return err;
> }
>
> --
> 2.16.4
>
next prev parent reply other threads:[~2019-10-18 9:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 7:45 [PATCH] xen/netback: fix error path of xenvif_connect_data() Juergen Gross
2019-10-18 9:10 ` Wei Liu [this message]
2019-10-19 18:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191018091026.fu4gykxx2mmbdfk3@debian \
--to=wei.liu@kernel.org \
--cc=davem@davemloft.net \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paul@xen.org \
--cc=stable@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).