From: Andrew Lunn <andrew@lunn.ch>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
netdev <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
open list <linux-kernel@vger.kernel.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
bcm-kernel-feedback-list@broadcom.com,
Russell King <rmk+kernel@armlinux.org.uk>,
cphealy@gmail.com, Jose Abreu <joabreu@synopsys.com>
Subject: Re: [PATCH net-next 2/2] net: phy: Add ability to debug RGMII connections
Date: Fri, 18 Oct 2019 15:01:21 +0200 [thread overview]
Message-ID: <20191018130121.GK4780@lunn.ch> (raw)
In-Reply-To: <CA+h21hrLHe2n0OxJyCKTU0r7mSB1zK9ggP1-1TCednFN_0rXfg@mail.gmail.com>
> Well, that's the tricky part. You're sending a frame out, with no
> guarantee you'll get the same frame back in. So I'm not sure that any
> identifiers put inside the frame will survive.
> How do the tests pan out for you? Do you actually get to trigger this
> check? As I mentioned, my NIC drops the frames with bad FCS.
My experience is, the NIC drops the frame and increments some the
counter about bad FCS. I do very occasionally see a frame delivered,
but i guess that is 1/65536 where the FCS just happens to be good by
accident. So i think some other algorithm should be used which is
unlikely to be good when the FCS is accidentally good, or just check
the contents of the packet, you know what is should contain.
Are there any NICs which don't do hardware FCS? Is that something we
realistically need to consider?
> Yes, but remember, nobody guarantees that a frame with DMAC
> ff:ff:ff:ff:ff:ff on egress will still have it on its way back. Again,
> this all depends on how you plan to manage the rx-all ethtool feature.
Humm. Never heard that before. Are you saying some NICs rewrite the
DMAN?
Andrew
next prev parent reply other threads:[~2019-10-18 13:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 22:49 [PATCH net-next 0/2] net: phy: Add ability to debug RGMII connections Florian Fainelli
2019-10-15 22:49 ` [PATCH net-next 1/2] net: phy: Use genphy_loopback() by default Florian Fainelli
2019-10-16 13:56 ` Andrew Lunn
2019-10-15 22:49 ` [PATCH net-next 2/2] net: phy: Add ability to debug RGMII connections Florian Fainelli
2019-10-16 8:55 ` Jose Abreu
2019-10-16 14:19 ` Andrew Lunn
2019-10-17 22:06 ` Vladimir Oltean
2019-10-17 22:22 ` Florian Fainelli
2019-10-17 22:49 ` Vladimir Oltean
2019-10-18 13:01 ` Andrew Lunn [this message]
2019-10-18 13:09 ` Vladimir Oltean
2019-10-18 13:23 ` Russell King - ARM Linux admin
2019-10-18 13:37 ` Vladimir Oltean
2019-10-18 13:54 ` Russell King - ARM Linux admin
2019-10-18 14:12 ` Vladimir Oltean
2019-10-18 16:01 ` Andrew Lunn
2019-10-17 19:24 ` [PATCH net-next 0/2] " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191018130121.GK4780@lunn.ch \
--to=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=cphealy@gmail.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=joabreu@synopsys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).