From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4BF3CA9EA0 for ; Fri, 18 Oct 2019 19:14:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AC6742070B for ; Fri, 18 Oct 2019 19:14:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="DqHXfO5K" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2443250AbfJRTOY (ORCPT ); Fri, 18 Oct 2019 15:14:24 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:53232 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2436517AbfJRTOY (ORCPT ); Fri, 18 Oct 2019 15:14:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=uOGFhvWAOHYOd3SMNOBvMaqJx6e/h1fD+87RpUGL3JA=; b=DqHXfO5K7qpUVaIl5ayJXP8tBm icn61OE8mn1aq4PX0ehbF76hEvR44IldjsJb8LhYbqOcI8VmxuskMupU91pZhDVnEV7BZ9tIa5C1q oNzSLnHLl7j+Sy9yEgQIxL4DQ96CcmnoU+WJjjxkdOswUbOHWi7SItxXE/jl+5ai8Udg=; Received: from andrew by vps0.lunn.ch with local (Exim 4.92.2) (envelope-from ) id 1iLXhc-0002rk-Qx; Fri, 18 Oct 2019 21:14:20 +0200 Date: Fri, 18 Oct 2019 21:14:20 +0200 From: Andrew Lunn To: Antoine Tenart Cc: davem@davemloft.net, alexandre.belloni@bootlin.com, nicolas.ferre@microchip.com, netdev@vger.kernel.org, thomas.petazzoni@bootlin.com, Russell King Subject: Re: [PATCH net-next] net: macb: convert to phylink Message-ID: <20191018191420.GI24810@lunn.ch> References: <20191018143924.7375-1-antoine.tenart@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191018143924.7375-1-antoine.tenart@bootlin.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > + if (bp->caps & MACB_CAPS_GIGABIT_MODE_AVAILABLE && > + (state->interface == PHY_INTERFACE_MODE_NA || > + state->interface == PHY_INTERFACE_MODE_GMII || > + state->interface == PHY_INTERFACE_MODE_SGMII || > + phy_interface_mode_is_rgmii(state->interface))) { > + phylink_set(mask, 1000baseT_Full); > + phylink_set(mask, 1000baseX_Full); > + > + if (!(bp->caps & MACB_CAPS_NO_GIGABIT_HALF)) > + phylink_set(mask, 1000baseT_Half); > + } > + > + bitmap_and(supported, supported, mask, __ETHTOOL_LINK_MODE_MASK_NBITS); > + bitmap_and(state->advertising, state->advertising, mask, > + __ETHTOOL_LINK_MODE_MASK_NBITS); > +} > + > +static int macb_mac_link_state(struct phylink_config *config, > + struct phylink_link_state *state) > +{ > + return -EOPNOTSUPP; > +} The hardware supports SGMII, but you have no way of knowing if the SGMII link is up? That seems odd. Andrew