From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Shannon Nelson <snelson@pensando.io>,
Pensando Drivers <drivers@pensando.io>,
"David S. Miller" <davem@davemloft.net>,
Jason Baron <jbaron@akamai.com>,
Andrew Morton <akpm@linux-foundation.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dynamic_debug: provide dynamic_hex_dump stub
Date: Tue, 22 Oct 2019 12:56:40 -0700 [thread overview]
Message-ID: <20191022125640.02f02424@cakuba.netronome.com> (raw)
In-Reply-To: <20190918195607.2080036-1-arnd@arndb.de>
On Wed, 18 Sep 2019 21:55:11 +0200, Arnd Bergmann wrote:
> The ionic driver started using dymamic_hex_dump(), but
> that is not always defined:
>
> drivers/net/ethernet/pensando/ionic/ionic_main.c:229:2: error: implicit declaration of function 'dynamic_hex_dump' [-Werror,-Wimplicit-function-declaration]
>
> Add a dummy implementation to use when CONFIG_DYNAMIC_DEBUG
> is disabled, printing nothing.
>
> Fixes: 938962d55229 ("ionic: Add adminq action")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Patch applied to net/master, thanks!
prev parent reply other threads:[~2019-10-22 19:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 19:55 [PATCH] dynamic_debug: provide dynamic_hex_dump stub Arnd Bergmann
2019-09-18 20:47 ` Shannon Nelson
2019-10-22 0:48 ` Jakub Kicinski
2019-10-22 19:56 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191022125640.02f02424@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=drivers@pensando.io \
--cc=jbaron@akamai.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=snelson@pensando.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).