From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43B40CA9EC7 for ; Thu, 31 Oct 2019 01:08:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1C1D12080F for ; Thu, 31 Oct 2019 01:08:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726769AbfJaBI1 (ORCPT ); Wed, 30 Oct 2019 21:08:27 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:49202 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726272AbfJaBI0 (ORCPT ); Wed, 30 Oct 2019 21:08:26 -0400 Received: from localhost (unknown [IPv6:2601:601:9f00:1e2::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 287E414EB5D6E; Wed, 30 Oct 2019 18:08:26 -0700 (PDT) Date: Wed, 30 Oct 2019 18:08:25 -0700 (PDT) Message-Id: <20191030.180825.592258061800796198.davem@davemloft.net> To: vladbu@mellanox.com Cc: netdev@vger.kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, mleitner@redhat.com, dcaratti@redhat.com, mrv@mojatatu.com, roopa@cumulusnetworks.com Subject: Re: [PATCH net-next v2 0/8] Control action percpu counters allocation by netlink flag From: David Miller In-Reply-To: <20191030140907.18561-1-vladbu@mellanox.com> References: <20191030140907.18561-1-vladbu@mellanox.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 30 Oct 2019 18:08:26 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Vlad Buslov Date: Wed, 30 Oct 2019 16:08:59 +0200 > In order to allow configuring action counters allocation type at > runtime, implement following changes: > > - Implement helper functions to update the action counters and use them > in affected actions instead of updating counters directly. This steps > abstracts actions implementation from counter types that are being > used for particular action instance at runtime. > > - Modify the new helpers to use percpu counters if they were allocated > during action initialization and use regular counters otherwise. > > - Extend action UAPI TCA_ACT space with TCA_ACT_FLAGS field. Add > TCA_ACT_FLAGS_NO_PERCPU_STATS action flag and update > hardware-offloaded actions to not allocate percpu counters when the > flag is set. ... I like both how this is implemented and how the patch series was split up. Series applied, thank you.