From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: davem@davemloft.net, alexei.starovoitov@gmail.com,
bpf@vger.kernel.org, netdev@vger.kernel.org,
oss-drivers@netronome.com
Subject: Re: [PATCH net 0/3] fix BPF offload related bugs
Date: Fri, 1 Nov 2019 10:03:59 -0700 [thread overview]
Message-ID: <20191101100359.712d663a@cakuba.netronome.com> (raw)
In-Reply-To: <fe57af03-c42d-0f87-b712-30c5048764ad@iogearbox.net>
On Fri, 1 Nov 2019 13:10:13 +0100, Daniel Borkmann wrote:
> On 11/1/19 4:06 AM, Jakub Kicinski wrote:
> > Hi!
> >
> > test_offload.py catches some recently added bugs.
> >
> > First of a bug in test_offload.py itself after recent changes
> > to netdevsim is fixed.
> >
> > Second patch fixes a bug in cls_bpf, and last one addresses
> > a problem with the recently added XDP installation optimization.
> >
> > Jakub Kicinski (3):
> > selftests: bpf: Skip write only files in debugfs
> > net: cls_bpf: fix NULL deref on offload filter removal
> > net: fix installing orphaned programs
> >
> > net/core/dev.c | 3 ++-
> > net/sched/cls_bpf.c | 8 ++++++--
> > tools/testing/selftests/bpf/test_offload.py | 5 +++++
> > 3 files changed, 13 insertions(+), 3 deletions(-)
>
> Should this go via -bpf or -net? Either way is fine, but asking
> given it's BPF related fixes; planning to do a PR in the evening,
> set looks good to me in any case.
FWIW I'm fine either way, too. I made it net after Alexei wondered if
we should apply the revert to net-next, but since you took the revert
to bpf-next perhaps bpf makes sense.
To state the obvious the only thing that matters is for the revert to
be in net-next when these are merged into net-next (IOW bpf-next PR is
what matters most at this point ;)).
next prev parent reply other threads:[~2019-11-01 17:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-01 3:06 [PATCH net 0/3] fix BPF offload related bugs Jakub Kicinski
2019-11-01 3:06 ` [PATCH net 1/3] selftests: bpf: Skip write only files in debugfs Jakub Kicinski
2019-11-01 3:06 ` [PATCH net 2/3] net: cls_bpf: fix NULL deref on offload filter removal Jakub Kicinski
2019-11-01 3:07 ` [PATCH net 3/3] net: fix installing orphaned programs Jakub Kicinski
2019-11-01 12:10 ` [PATCH net 0/3] fix BPF offload related bugs Daniel Borkmann
2019-11-01 17:03 ` Jakub Kicinski [this message]
2019-11-01 22:16 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191101100359.712d663a@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=alexei.starovoitov@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).