From: David Miller <davem@davemloft.net>
To: andrew@lunn.ch
Cc: netdev@vger.kernel.org, dan.carpenter@oracle.com
Subject: Re: [PATCH v2 net-next] net: of_get_phy_mode: Change API to solve int/unit warnings
Date: Sun, 03 Nov 2019 19:44:09 -0800 (PST) [thread overview]
Message-ID: <20191103.194409.422094551811274424.davem@davemloft.net> (raw)
In-Reply-To: <20191103.192601.443764119268490765.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Sun, 03 Nov 2019 19:26:01 -0800 (PST)
> Applied, thanks Andrew.
I tried to fix some of the allmodconfig build fallout but it just kept
piling up. Can you fix this and resubmit? Thanks.
drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c: In function ‘dpaa2_mac_get_if_mode’:
drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c:49:12: error: too few arguments to function ‘of_get_phy_mode’
if_mode = of_get_phy_mode(node);
^~~~~~~~~~~~~~~
drivers/net/ethernet/stmicro/stmmac/dwmac-sti.c: In function ‘sti_dwmac_parse_data’:
drivers/net/ethernet/stmicro/stmmac/dwmac-sti.c:274:16: warning: too many arguments for format [-Wformat-extra-args]
dev_err(dev, "Can't get phy-mode\n", err);
^~~~~~~~~~~~~~~~~~~~~~
In file included from ./include/linux/platform_device.h:13,
from ./include/linux/stmmac.h:15,
from drivers/net/ethernet/stmicro/stmmac/dwmac-sunxi.c:10:
drivers/net/ethernet/stmicro/stmmac/dwmac-sunxi.c: In function ‘sun7i_gmac_probe’:
drivers/net/ethernet/stmicro/stmmac/dwmac-sunxi.c:123:16: warning: too many arguments for format [-Wformat-extra-args]
dev_err(dev, "Can't get phy-mode\n", ret);
^~~~~~~~~~~~~~~~~~~~~~
./include/linux/device.h:1658:22: note: in definition of macro ‘dev_fmt’
#define dev_fmt(fmt) fmt
^~~
drivers/net/ethernet/stmicro/stmmac/dwmac-sunxi.c:123:3: note: in expansion of macro ‘dev_err’
dev_err(dev, "Can't get phy-mode\n", ret);
^~~~~~~
next prev parent reply other threads:[~2019-11-04 3:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-01 22:07 [PATCH v2 net-next] net: of_get_phy_mode: Change API to solve int/unit warnings Andrew Lunn
2019-11-04 3:26 ` David Miller
2019-11-04 3:44 ` David Miller [this message]
2019-11-04 13:29 ` Andrew Lunn
2019-11-04 19:21 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191103.194409.422094551811274424.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=dan.carpenter@oracle.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).