From: David Miller <davem@davemloft.net>
To: jakub.kicinski@netronome.com
Cc: idosch@idosch.org, netdev@vger.kernel.org, jiri@mellanox.com,
shalomt@mellanox.com, mlxsw@mellanox.com, idosch@mellanox.com
Subject: Re: [PATCH net-next 0/6] mlxsw: Add extended ACK for EMADs
Date: Tue, 05 Nov 2019 17:58:18 -0800 (PST) [thread overview]
Message-ID: <20191105.175818.826509723756288899.davem@davemloft.net> (raw)
In-Reply-To: <20191105095448.1fbc25a5@cakuba.netronome.com>
From: Jakub Kicinski <jakub.kicinski@netronome.com>
Date: Tue, 5 Nov 2019 09:54:48 -0800
> Bottom line is I don't like when data from FW is just blindly passed
> to user space. Printing to the logs is perhaps the smallest of this
> sort of infractions but nonetheless if there is no precedent for doing
> this today I'd consider not opening this box.
I agree with Jakub and we should set this kind of precedence.
prev parent reply other threads:[~2019-11-06 1:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-03 8:35 [PATCH net-next 0/6] mlxsw: Add extended ACK for EMADs Ido Schimmel
2019-11-03 8:35 ` [PATCH net-next 1/6] mlxsw: core: Parse TLVs' offsets of incoming EMADs Ido Schimmel
2019-11-03 8:35 ` [PATCH net-next 2/6] mlxsw: emad: Remove deprecated EMAD TLVs Ido Schimmel
2019-11-03 8:35 ` [PATCH net-next 3/6] mlxsw: core: Add EMAD string TLV Ido Schimmel
2019-11-03 8:35 ` [PATCH net-next 4/6] mlxsw: core: Add support for EMAD string TLV parsing Ido Schimmel
2019-11-03 8:35 ` [PATCH net-next 5/6] mlxsw: core: Add support for using EMAD string TLV Ido Schimmel
2019-11-03 8:35 ` [PATCH net-next 6/6] mlxsw: spectrum: Enable " Ido Schimmel
2019-11-04 20:39 ` [PATCH net-next 0/6] mlxsw: Add extended ACK for EMADs Jakub Kicinski
2019-11-04 21:04 ` Ido Schimmel
2019-11-04 22:44 ` Jakub Kicinski
2019-11-04 23:20 ` Ido Schimmel
2019-11-04 23:33 ` Jakub Kicinski
2019-11-05 7:46 ` Ido Schimmel
2019-11-05 17:54 ` Jakub Kicinski
2019-11-05 20:48 ` Ido Schimmel
2019-11-05 21:48 ` Jakub Kicinski
2019-11-06 8:20 ` Jiri Pirko
2019-11-06 17:26 ` Jakub Kicinski
2019-11-07 9:42 ` Jiri Pirko
2019-11-06 1:58 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191105.175818.826509723756288899.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=idosch@idosch.org \
--cc=idosch@mellanox.com \
--cc=jakub.kicinski@netronome.com \
--cc=jiri@mellanox.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=shalomt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).