From: David Miller <davem@davemloft.net>
To: chenwandun@huawei.com
Cc: ruxandra.radulescu@nxp.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dpaa2-ptp: fix compile error
Date: Wed, 06 Nov 2019 10:24:25 -0800 (PST) [thread overview]
Message-ID: <20191106.102425.1829408448491863676.davem@davemloft.net> (raw)
In-Reply-To: <1572967232-96724-1-git-send-email-chenwandun@huawei.com>
From: Chen Wandun <chenwandun@huawei.com>
Date: Tue, 5 Nov 2019 23:20:32 +0800
> From: Chenwandun <chenwandun@huawei.com>
>
> phylink_set_port_modes will be compiled if CONFIG_PHYLINK enabled,
> dpaa2_mac_validate will be compiled if CONFIG_FSL_DPAA2_ETH enabled,
> it should select CONFIG_PHYLINK when dpaa2_mac_validate call
> phylink_set_port_modes
>
> drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.o: In function `dpaa2_mac_validate':
> dpaa2-mac.c:(.text+0x3a1): undefined reference to `phylink_set_port_modes'
> drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.o: In function `dpaa2_mac_connect':
> dpaa2-mac.c:(.text+0x91a): undefined reference to `phylink_create'
> dpaa2-mac.c:(.text+0x94e): undefined reference to `phylink_of_phy_connect'
> dpaa2-mac.c:(.text+0x97f): undefined reference to `phylink_destroy'
> drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.o: In function `dpaa2_mac_disconnect':
> dpaa2-mac.c:(.text+0xa9f): undefined reference to `phylink_disconnect_phy'
> dpaa2-mac.c:(.text+0xab0): undefined reference to `phylink_destroy'
> make: *** [vmlinux] Error 1
You need to add a proper Signed-off-by: and Fixes: tag.
prev parent reply other threads:[~2019-11-06 18:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-05 15:20 [PATCH] dpaa2-ptp: fix compile error Chen Wandun
2019-11-06 18:24 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191106.102425.1829408448491863676.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=chenwandun@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ruxandra.radulescu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).