netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Salil Mehta <salil.mehta@huawei.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"lipeng (Y)" <lipeng321@huawei.com>,
	"Zhuangyuzeng (Yisen)" <yisen.zhuang@huawei.com>,
	"David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH] net: hns: Ensure that interface teardown cannot race with TX interrupt
Date: Wed, 6 Nov 2019 08:17:48 +0000	[thread overview]
Message-ID: <20191106081748.0e21554c@why> (raw)
In-Reply-To: <aa7d625e74c74e4b9810b8ea3e437ca4@huawei.com>

On Tue, 5 Nov 2019 18:41:11 +0000
Salil Mehta <salil.mehta@huawei.com> wrote:

Hi Salil,

> Hi Marc,
> I tested with the patch on D05 with the lockdep enabled kernel with below options
> and I could not reproduce the deadlock. I do not argue the issue being mentioned
> as this looks to be a clear bug which should hit while TX data-path is running
> and we try to disable the interface.

Lockdep screaming at you doesn't mean the deadly scenario happens in
practice, and I've never seen the machine hanging in these conditions.
But I've also never tried to trigger it in anger.

> Could you please help me know the exact set of steps you used to get into this
> problem. Also, are you able to re-create it easily/frequently?

I just need to issue "reboot" (which calls "ip link ... down") for this
to trigger. Here's a full splat[1], as well as my full config[2]. It is
100% repeatable.

> # Kernel Config options:
> CONFIG_LOCKDEP_SUPPORT=y
> CONFIG_LOCKDEP=y

You'll need at least 

CONFIG_PROVE_LOCKING=y
CONFIG_NET_POLL_CONTROLLER=y

in order to hit it.

Thanks,

	M.

[1] https://paste.debian.net/1114451/
[2] https://paste.debian.net/1114472/
-- 
Jazz is not dead. It just smells funny...

  reply	other threads:[~2019-11-06  8:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-04 19:56 [PATCH] net: hns: Ensure that interface teardown cannot race with TX interrupt Marc Zyngier
2019-11-05  9:16 ` Salil Mehta
2019-11-05 18:41 ` Salil Mehta
2019-11-06  8:17   ` Marc Zyngier [this message]
2019-11-06 11:19     ` Salil Mehta
2019-11-06 12:16       ` Marc Zyngier
2019-11-06 19:05         ` Salil Mehta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191106081748.0e21554c@why \
    --to=maz@kernel.org \
    --cc=davem@davemloft.net \
    --cc=lipeng321@huawei.com \
    --cc=netdev@vger.kernel.org \
    --cc=salil.mehta@huawei.com \
    --cc=yisen.zhuang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).