From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_SBL,URIBL_SBL_A,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D820EC5DF60 for ; Fri, 8 Nov 2019 11:13:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AB0A820869 for ; Fri, 8 Nov 2019 11:13:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="u7QLJGpn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730944AbfKHLNY (ORCPT ); Fri, 8 Nov 2019 06:13:24 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:36245 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725730AbfKHLNY (ORCPT ); Fri, 8 Nov 2019 06:13:24 -0500 Received: by mail-wr1-f68.google.com with SMTP id r10so6608102wrx.3 for ; Fri, 08 Nov 2019 03:13:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=K+Eo0glUzjalQHt6xvHUxzQrB7u3vMyGwdCkPxcCzJY=; b=u7QLJGpnAhW16VTXD/Gmf8wGHRwCNuydIXbhIRkLruxGqEccaxt4cGg+fjCalmVcOH 36Vd0JvzO7da+wUXNT3V7+HSK1Ak9QtB8AuiV3bPkf3ku/uVPT+oloU5+jUGD2S2+/P4 d45RFmwEibq89tq5v02AUDRgfiUy6X0543v0SOq7NsDMKInckdUU+l0VJ7nBrLE8Z0vI sNOBy5SfOQ1d6nS9qVKJu5WyGhqxC0uNvi5MMfN1SfJAYUg3rdUO+dLzD/O2DhtpCIzB o6Xq6h3x0FdW3fKMLJxO4io6+EZL4HhQkBOOWSHmxWC9IjclTTL88meL/fwkc95abNHq QkZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=K+Eo0glUzjalQHt6xvHUxzQrB7u3vMyGwdCkPxcCzJY=; b=IN7B4ev2NvdkaWbCcW38sqD3D/EgUk5kUPAetVm77Prouot6kxQJdLy/MX6m3bg/Tj Zqt8SnHCvDkVJrdgl7h5b74s3jm9SpH6yxbyKroXRJvrgXtXsytMh3xCsU5nyRp8HQMW edAIKS4AZy7krrI3IXOC47P3PDnwlvOt3wIvVRv7u4rcBwvMBi8oCJ+nKb5BJvGjxDuY n8zdNVXpHtK+5fWci1Ehhg3ZFGELpJ+uVyYLLeE5aq3NKf1/NgeFxiJUEvRjE0CvlW8T e0Zs7KQeIPTnG2iq9Nhi+rEcyX8zQnvIufNfvrt5iyX6NewQ/4cnvQ3+3nhEumvKDVao NItw== X-Gm-Message-State: APjAAAXpdJkrwkKihPMit45jMMBX4w0c/lt6Dj9udMYwyQvVDY6186kK fitp4tssmPzY4pX99wQfGu3oeQ== X-Google-Smtp-Source: APXvYqwnP2QDmQBcfmJLh3FRIv+V4z/O+BIfKcf6B34Ft5wA/wQ3rdOItRHB5FmTkCO/S9Z5vQlKng== X-Received: by 2002:adf:e346:: with SMTP id n6mr7240613wrj.234.1573211601794; Fri, 08 Nov 2019 03:13:21 -0800 (PST) Received: from localhost (ip-94-113-220-175.net.upcbroadband.cz. [94.113.220.175]) by smtp.gmail.com with ESMTPSA id 11sm4575378wmi.8.2019.11.08.03.13.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Nov 2019 03:13:21 -0800 (PST) Date: Fri, 8 Nov 2019 12:13:20 +0100 From: Jiri Pirko To: Parav Pandit Cc: alex.williamson@redhat.com, davem@davemloft.net, kvm@vger.kernel.org, netdev@vger.kernel.org, saeedm@mellanox.com, kwankhede@nvidia.com, leon@kernel.org, cohuck@redhat.com, jiri@mellanox.com, linux-rdma@vger.kernel.org, Vu Pham Subject: Re: [PATCH net-next 15/19] net/mlx5: Add load/unload routines for SF driver binding Message-ID: <20191108111320.GI6990@nanopsycho> References: <20191107160448.20962-1-parav@mellanox.com> <20191107160834.21087-1-parav@mellanox.com> <20191107160834.21087-15-parav@mellanox.com> <20191108094854.GC6990@nanopsycho> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191108094854.GC6990@nanopsycho> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fri, Nov 08, 2019 at 10:48:54AM CET, jiri@resnulli.us wrote: >Thu, Nov 07, 2019 at 05:08:30PM CET, parav@mellanox.com wrote: >>Add SF load/unload helper routines which will be used during >>binding/unbinding a SF to mlx5_core driver as mediated device. >> >>Reviewed-by: Saeed Mahameed >>Signed-off-by: Vu Pham >>Signed-off-by: Parav Pandit >>--- >> .../net/ethernet/mellanox/mlx5/core/main.c | 11 ++- >> .../ethernet/mellanox/mlx5/core/meddev/sf.c | 67 +++++++++++++++++++ > >Nit: Why not s/meddev/mdev/ ? I think that "mdev" is widely recognized term. I take it back after grepping drivers/net/ethernet/mellanox/mlx5/core/ for mdev :) > >[...]