From: David Miller <davem@davemloft.net>
To: sd@queasysnail.net
Cc: netdev@vger.kernel.org, herbert@gondor.apana.org.au,
steffen.klassert@secunet.com, jakub.kicinski@netronome.com
Subject: Re: [PATCH net-next v5 0/6] ipsec: add TCP encapsulation support (RFC 8229)
Date: Tue, 12 Nov 2019 12:23:01 -0800 (PST) [thread overview]
Message-ID: <20191112.122301.947461264517400659.davem@davemloft.net> (raw)
In-Reply-To: <cover.1573487190.git.sd@queasysnail.net>
From: Sabrina Dubroca <sd@queasysnail.net>
Date: Tue, 12 Nov 2019 16:18:37 +0100
> This patchset introduces support for TCP encapsulation of IKE and ESP
> messages, as defined by RFC 8229 [0]. It is an evolution of what
> Herbert Xu proposed in January 2018 [1] that addresses the main
> criticism against it, by not interfering with the TCP implementation
> at all. The networking stack now has infrastructure for this: TCP ULPs
> and Stream Parsers.
>
> The first patches are preparation and refactoring, and the final patch
> adds the feature.
>
> The main omission in this submission is IPv6 support. ESP
> encapsulation over UDP with IPv6 is currently not supported in the
> kernel either, as UDP encapsulation is aimed at NAT traversal, and NAT
> is not frequently used with IPv6.
>
> Some of the code is taken directly, or slightly modified, from Herbert
> Xu's original submission [1]. The ULP and strparser pieces are
> new. This work was presented and discussed at the IPsec workshop and
> netdev 0x13 conference [2] in Prague, last March.
>
> [0] https://tools.ietf.org/html/rfc8229
> [1] https://patchwork.ozlabs.org/patch/859107/
> [2] https://netdevconf.org/0x13/session.html?talk-ipsec-encap
...
This looks generally fine to me, and I assume Steffen will pick this up
and integrate it into his ipsec-next tree.
For the series:
Acked-by: David S. Miller <davem@davemloft.net>
next prev parent reply other threads:[~2019-11-12 20:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 15:18 [PATCH net-next v5 0/6] ipsec: add TCP encapsulation support (RFC 8229) Sabrina Dubroca
2019-11-12 15:18 ` [PATCH net-next v5 1/6] net: add queue argument to __skb_wait_for_more_packets and __skb_{,try_}recv_datagram Sabrina Dubroca
2019-11-12 17:54 ` Eric Dumazet
2019-11-13 10:57 ` Sabrina Dubroca
2019-11-12 15:18 ` [PATCH net-next v5 2/6] xfrm: introduce xfrm_trans_queue_net Sabrina Dubroca
2019-11-12 15:18 ` [PATCH net-next v5 3/6] xfrm: add route lookup to xfrm4_rcv_encap Sabrina Dubroca
2019-11-12 15:18 ` [PATCH net-next v5 4/6] esp4: prepare esp_input_done2 for non-UDP encapsulation Sabrina Dubroca
2019-11-12 15:18 ` [PATCH net-next v5 5/6] esp4: split esp_output_udp_encap and introduce esp_output_encap Sabrina Dubroca
2019-11-12 15:18 ` [PATCH net-next v5 6/6] xfrm: add espintcp (RFC 8229) Sabrina Dubroca
2019-11-12 20:23 ` David Miller [this message]
2019-11-21 5:51 ` [PATCH net-next v5 0/6] ipsec: add TCP encapsulation support " Steffen Klassert
2019-11-21 9:35 ` Sabrina Dubroca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191112.122301.947461264517400659.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jakub.kicinski@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=sd@queasysnail.net \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).