From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 378F9C43331 for ; Tue, 12 Nov 2019 13:44:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0BFBC2084F for ; Tue, 12 Nov 2019 13:44:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="aGp8OKOT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727229AbfKLNoz (ORCPT ); Tue, 12 Nov 2019 08:44:55 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:35826 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725919AbfKLNoy (ORCPT ); Tue, 12 Nov 2019 08:44:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=MV3cj6nhezWpTUxJkb0VGotbUmCUoYWfEaZdrcgaYbY=; b=aGp8OKOT6G+VGBbzK+uDpmED7T UEzxUl90o0fgYy2XPZQXTODljgG7+ep+FzJvGRtyfmPhFtBhtpesJalVGrMb7A8nfclRtZFh/5H0R ggsgdRpSm6h6RBx371Xm1rs+bpwnU6mboQxEZXF/U2Qzc40WikhTOPX/DHltPaJrPO44=; Received: from andrew by vps0.lunn.ch with local (Exim 4.92.2) (envelope-from ) id 1iUWTS-0001ex-PY; Tue, 12 Nov 2019 14:44:50 +0100 Date: Tue, 12 Nov 2019 14:44:50 +0100 From: Andrew Lunn To: Vladimir Oltean Cc: jakub.kicinski@netronome.com, davem@davemloft.net, alexandre.belloni@bootlin.com, f.fainelli@gmail.com, vivien.didelot@gmail.com, joergen.andreasen@microchip.com, allan.nielsen@microchip.com, horatiu.vultur@microchip.com, claudiu.manoil@nxp.com, netdev@vger.kernel.org, Vladimir Oltean Subject: Re: [PATCH net-next 05/12] net: mscc: ocelot: export a constant for the tag length in bytes Message-ID: <20191112134450.GG5090@lunn.ch> References: <20191112124420.6225-1-olteanv@gmail.com> <20191112124420.6225-6-olteanv@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191112124420.6225-6-olteanv@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Nov 12, 2019 at 02:44:13PM +0200, Vladimir Oltean wrote: 65;5800;1c> From: Vladimir Oltean > > This constant will be used in a future patch to increase the MTU on NPI > ports, and will also be used in the tagger driver for Felix. Another example of the next patch explaining the previous patch :-) Maybe this indicates the 'why' is missing from the commit messages? Reviewed-by: Andrew Lunn Andrew