From: David Miller <davem@davemloft.net>
To: cforno12@linux.vnet.ibm.com
Cc: netdev@vger.kernel.org, tlfalcon@linux.ibm.com
Subject: Re: [PATCH net-next] ibmveth: Detect unsupported packets before sending to the hypervisor
Date: Wed, 13 Nov 2019 12:23:07 -0800 (PST) [thread overview]
Message-ID: <20191113.122307.27797700143710756.davem@davemloft.net> (raw)
In-Reply-To: <20191113154407.50653-1-cforno12@linux.vnet.ibm.com>
From: Cris Forno <cforno12@linux.vnet.ibm.com>
Date: Wed, 13 Nov 2019 09:44:07 -0600
> @@ -1011,6 +1011,29 @@ static int ibmveth_send(struct ibmveth_adapter *adapter,
> return 0;
> }
>
> +static int ibmveth_is_packet_unsupported(struct sk_buff *skb,
> + struct net_device *netdev)
> +{
> + int ret = 0;
> + struct ethhdr *ether_header;
Please use reverse christmas tree ordering for these local variables.
Thanks.
next prev parent reply other threads:[~2019-11-13 20:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 15:44 [PATCH net-next] ibmveth: Detect unsupported packets before sending to the hypervisor Cris Forno
2019-11-13 17:21 ` Thomas Falcon
2019-11-13 20:23 ` David Miller [this message]
2019-11-13 20:28 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191113.122307.27797700143710756.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=cforno12@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=tlfalcon@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).