From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59470C432C3 for ; Wed, 13 Nov 2019 22:59:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2FD7F206EE for ; Wed, 13 Nov 2019 22:59:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="R0eY7mrK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726599AbfKMW7n (ORCPT ); Wed, 13 Nov 2019 17:59:43 -0500 Received: from mail-pf1-f195.google.com ([209.85.210.195]:37887 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726251AbfKMW7n (ORCPT ); Wed, 13 Nov 2019 17:59:43 -0500 Received: by mail-pf1-f195.google.com with SMTP id p24so2691559pfn.4 for ; Wed, 13 Nov 2019 14:59:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=x0ZnUt6kpEl8U4BFQc25DnqaMomOkgg87tNLp5MJobU=; b=R0eY7mrKlGW/OVdYhbPMbOVBf7QxU9dLQqSt3WiiDoDKS8ojUQSuj1cJ5zzMazX1hb JTqeimnK15zfrigBOGnw0Bq7/sqQhFU7tOw6X+B5iKTiTR7mMr7rGAtEACGGrXe9fPkb NkZK+FmDj/EJuSRG5oerEwQbu/cKivtP2hZ5jDuw0hXdKcfw/7q15elq09GfpcEcv4K8 nOafiv1azzgJ4A5F06hFgXH+xgleCBpIXU0JUe3AqkqfY8rTXWJc/yCQJ3i0pkFvBJ0R kTH0JQ6jMtGy9iIKtMI6NdCt3sBNByqTV1Ht2VTohQOqc9LKt4pbZXkupbvBxiGoVq7T tRLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=x0ZnUt6kpEl8U4BFQc25DnqaMomOkgg87tNLp5MJobU=; b=sU2FLyB3Z4NrqiyveI0/2O6/EYjcQgNbHZn4QnhoZ4mZhSRtH26rbh7SV/OV5Opelj RKmZc1gTWW+Go4BgRt5lsjW7iqpCTAuvp6k2JQkd+uC2/LV6cU1fDIdfoIm1JMpb2325 gCV1AuMwjoFPEY3U1Z6aNqxh2b1NxHopfDc+B7B45BP8OC66WI3gySzQRR/xDNRnb+Td NYFx+w9q/t199+n7sZW3/OFfuUsPCK7LFpP1bw/UmnFVrURJ1cT8rqu7MQa2qXTzNjoE k82xyv3Rbvs8B81d1pgdrd9omVihcxK2RFRzLJyw9Z6j+8sTHUd4VCMd/VzWmZ3nSB+6 8gyA== X-Gm-Message-State: APjAAAVx5lFsp1Cr6+FYCxo9pilvzra9JYhLvdlYxCsgpBmn4T64ZnaX ij3sA4TmQi+y3TN0RjpUard6WA== X-Google-Smtp-Source: APXvYqxB6VnLMk6EwZYMzfe4Eo4jDzf5CFGuPJT1iqW0GcmV//9bJ9nx8dCxRAqDYoD6u/PuzXc5Nw== X-Received: by 2002:a17:90a:3264:: with SMTP id k91mr8088584pjb.23.1573685981680; Wed, 13 Nov 2019 14:59:41 -0800 (PST) Received: from builder (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id h13sm4557008pfr.98.2019.11.13.14.59.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Nov 2019 14:59:41 -0800 (PST) Date: Wed, 13 Nov 2019 14:59:38 -0800 From: Bjorn Andersson To: Jeffrey Hugo Cc: kvalo@codeaurora.org, davem@davemloft.net, ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ath10k: Handle when FW doesn't support QMI_WLFW_HOST_CAP_REQ_V01 Message-ID: <20191113225938.GA3727453@builder> References: <20191106233130.2169-1-jeffrey.l.hugo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191106233130.2169-1-jeffrey.l.hugo@gmail.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed 06 Nov 15:31 PST 2019, Jeffrey Hugo wrote: > Firmware with the build id QC_IMAGE_VERSION_STRING=WLAN.HL.1.0.2-XXXX does > not support the QMI_WLFW_HOST_CAP_REQ_V01 message and will return the > QMI not supported error to the ath10k driver. Since not supporting this > message is not fatal to the firmware nor the ath10k driver, lets catch > this particular scenario and ignore it so that we can still bring up > wifi services successfully. > Reviewed-by: Bjorn Andersson > Signed-off-by: Jeffrey Hugo > --- > drivers/net/wireless/ath/ath10k/qmi.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/ath10k/qmi.c b/drivers/net/wireless/ath/ath10k/qmi.c > index 545ac1f06997..eb618a2652db 100644 > --- a/drivers/net/wireless/ath/ath10k/qmi.c > +++ b/drivers/net/wireless/ath/ath10k/qmi.c > @@ -614,7 +614,9 @@ static int ath10k_qmi_host_cap_send_sync(struct ath10k_qmi *qmi) > if (ret < 0) > goto out; > > - if (resp.resp.result != QMI_RESULT_SUCCESS_V01) { > + /* older FW didn't support this request, which is not fatal */ > + if (resp.resp.result != QMI_RESULT_SUCCESS_V01 && > + resp.resp.error != QMI_ERR_NOT_SUPPORTED_V01) { > ath10k_err(ar, "host capability request rejected: %d\n", resp.resp.error); > ret = -EINVAL; > goto out; > -- > 2.17.1 >