From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59D95C43215 for ; Fri, 15 Nov 2019 22:44:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 32A9A20733 for ; Fri, 15 Nov 2019 22:44:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727217AbfKOWoH (ORCPT ); Fri, 15 Nov 2019 17:44:07 -0500 Received: from correo.us.es ([193.147.175.20]:50020 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727032AbfKOWoH (ORCPT ); Fri, 15 Nov 2019 17:44:07 -0500 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id A1136FB46B for ; Fri, 15 Nov 2019 23:44:03 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 91CFDA7BEA for ; Fri, 15 Nov 2019 23:44:03 +0100 (CET) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 8E4CFDA4CA; Fri, 15 Nov 2019 23:44:03 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 6489DDA4CA; Fri, 15 Nov 2019 23:44:01 +0100 (CET) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Fri, 15 Nov 2019 23:44:01 +0100 (CET) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (sys.soleta.eu [212.170.55.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 209CF426CCBA; Fri, 15 Nov 2019 23:44:01 +0100 (CET) Date: Fri, 15 Nov 2019 23:44:02 +0100 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Arnd Bergmann Cc: y2038@lists.linaro.org, Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , linux-kernel@vger.kernel.org, Ander Juaristi , wenxu , Thomas Gleixner , Phil Sutter , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org Subject: Re: [PATCH 09/16] netfilter: nft_meta: use 64-bit time arithmetic Message-ID: <20191115224402.twm2lbbd66236t42@salvia> References: <20191108213257.3097633-1-arnd@arndb.de> <20191108213257.3097633-10-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191108213257.3097633-10-arnd@arndb.de> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Nov 08, 2019 at 10:32:47PM +0100, Arnd Bergmann wrote: > On 32-bit architectures, get_seconds() returns an unsigned 32-bit > time value, which also matches the type used in the nft_meta > code. This will not overflow in year 2038 as a time_t would, but > it still suffers from the overflow problem later on in year 2106. > > Change this instance to use the time64_t type consistently > and avoid the deprecated get_seconds(). > > The nft_meta_weekday() calculation potentially gets a little slower > on 32-bit architectures, but now it has the same behavior as on > 64-bit architectures and does not overflow. Applied, thanks Arnd.