From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD25AC432C0 for ; Tue, 19 Nov 2019 19:15:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B4C5722440 for ; Tue, 19 Nov 2019 19:15:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="XE0/ul2U" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727336AbfKSTPt (ORCPT ); Tue, 19 Nov 2019 14:15:49 -0500 Received: from mail-qk1-f196.google.com ([209.85.222.196]:34031 "EHLO mail-qk1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726892AbfKSTPt (ORCPT ); Tue, 19 Nov 2019 14:15:49 -0500 Received: by mail-qk1-f196.google.com with SMTP id 205so18914794qkk.1 for ; Tue, 19 Nov 2019 11:15:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=wzoIv3PgQ5xg77XVjLm23G3rCo4a5omAce2oLdpNLf0=; b=XE0/ul2UH6r1RgftX+x3FfxRVtupCc0p5j0CssMbeJpj9XpIfEt7ladYWvfy54o6Rg amj5FPwjOky3fb6cVFljYWKTaVErqw09vP6ui7h+2TyUDXQCqE70A37nvgt7HyZHrxf3 V8JUDy38dL0v1I7A9N5JdjR6YDfEaFMIToaDZunT+tn8ckvBTwGr3IpDyuqEmRjiHgMH q2ZF0rGJkIdipvVsCY3GQEa0Qj+LYYmBMvgm3d1hv8DF+ar6Gg7dHjFuyFaUPTfKOwKF eaurWEbbTu1OVxsgNwi+CoRdCzltDRJW+MyY+sIifQYyLzEUKqiGh4y8eqxhprl0CCkp Abeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=wzoIv3PgQ5xg77XVjLm23G3rCo4a5omAce2oLdpNLf0=; b=sz41/rLSEF/ONGWRt5WpeRv32yb8FRCCS5JxZO+uSW8iVl08Qp9YY5c9FNgq75CW99 Lfl1pWRuwdKq7t642GZQFPf4QuZefUJ66RtNtwHbFd8+ZlBfbFiP48Z8lLu77lfB2UY4 9H9xlFlo19uwLx4ot7NSlwc7zfegTBB3yxcLjJlN41uDbOTsIhuZjgjSmFKCSSEFoSzJ fe6x/11A0nKAQ68fLiAd3TX9wXUWMURHv21hI0vnPJXLfiSXRTBWezAzB6KpBwJjP6p2 imnFn9ejTh6vxlCyZ4gv/Jo3Ul+G3uWrxHHo193png9o1xhGbtdZc9U9eg7IW/PFAN/L gBIQ== X-Gm-Message-State: APjAAAW6rWkDxiIPDFdMb2kUwmzX5DO+2nzXXpwmXbWNXiphbqdwp4tW 8QlQJA6DfMQBPFck/NyBMG3vgg== X-Google-Smtp-Source: APXvYqxRNsEg1levwxBxtexcCKoGDcNnCXh67oEXnQ2zgfRUQ9XoNmJhJPOHNIKTRGaI5LuduX6avA== X-Received: by 2002:a37:9f48:: with SMTP id i69mr30497457qke.273.1574190948542; Tue, 19 Nov 2019 11:15:48 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-113-180.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.180]) by smtp.gmail.com with ESMTPSA id m13sm10540375qka.109.2019.11.19.11.15.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 19 Nov 2019 11:15:48 -0800 (PST) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1iX8yZ-0002e8-NJ; Tue, 19 Nov 2019 15:15:47 -0400 Date: Tue, 19 Nov 2019 15:15:47 -0400 From: Jason Gunthorpe To: "Michael S. Tsirkin" Cc: Jason Wang , Parav Pandit , Jeff Kirsher , "davem@davemloft.net" , "gregkh@linuxfoundation.org" , Dave Ertman , "netdev@vger.kernel.org" , "linux-rdma@vger.kernel.org" , "nhorman@redhat.com" , "sassmann@redhat.com" , Kiran Patil , Alex Williamson , "Bie, Tiwei" Subject: Re: [net-next v2 1/1] virtual-bus: Implementation of Virtual Bus Message-ID: <20191119191547.GL4991@ziepe.ca> References: <20191115223355.1277139-1-jeffrey.t.kirsher@intel.com> <13946106-dab2-6bbe-df79-ca6dfdeb4c51@redhat.com> <20191119164632.GA4991@ziepe.ca> <20191119134822-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191119134822-mutt-send-email-mst@kernel.org> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Nov 19, 2019 at 01:58:42PM -0500, Michael S. Tsirkin wrote: > On Tue, Nov 19, 2019 at 12:46:32PM -0400, Jason Gunthorpe wrote: > > As always, this is all very hard to tell without actually seeing real > > accelerated drivers implement this. > > > > Your patch series might be a bit premature in this regard. > > Actually drivers implementing this have been posted, haven't they? > See e.g. https://lwn.net/Articles/804379/ Is that a real driver? It looks like another example quality thing. For instance why do we need any of this if it has '#define IFCVF_MDEV_LIMIT 1' ? Surely for this HW just use vfio over the entire PCI function and be done with it? Jason