netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Petko Manolov <petkan@nucleusys.com>
To: Thor Thayer <thor.thayer@linux.intel.com>
Cc: netdev@vger.kernel.org
Subject: Altera TSE driver not working in 100mbps mode
Date: Wed, 27 Nov 2019 15:54:19 +0200	[thread overview]
Message-ID: <20191127135419.7r53qw6vtp747x62@p310> (raw)

	Hi Thor,

In my effort to move Altera TSE driver from PHYLIB to PHYLINK i ran into a 
problem.  The driver would not work properly on 100Mbit/s links.  This is true 
for the original driver in linux-5.4.y as well as for my PHYLINK/SFP enabled 
version.

This is a DT fragment of what i've been trying with 5.4.y kernels and the 
stock driver:

                tse_sub_2: ethernet@0xc0300000 {
                        status = "disabled";

                        compatible = "altr,tse-msgdma-1.0";
                        reg =   <0xc0300000 0x00000400>,
                                <0xc0301000 0x00000020>,
                                <0xc0302000 0x00000020>,
                                <0xc0303000 0x00000008>,
                                <0xc0304000 0x00000020>,
                                <0xc0305000 0x00000020>;
                        reg-names = "control_port", "rx_csr", "rx_desc", "rx_resp", "tx_csr", "tx_desc";
                        interrupt-parent =< &intc >;
                        interrupts = <0 54 4>, <0 55 4>;
                        interrupt-names = "rx_irq", "tx_irq";
                        rx-fifo-depth = <2048>;
                        tx-fifo-depth = <2048>;
                        address-bits = <48>;
                        max-frame-size = <1500>;
                        local-mac-address = [ 00 0C ED 00 00 06 ];
                        altr,has-supplementary-unicast;
                        altr,has-hash-multicast-filter;
                        phy-handle = <0>;
                        fixed-link {
                                speed = <1000>;
                                full-duplex;
                        };
                };

Trying "speed = <100>;" above also doesn't change much, except that the link is 
reported (as expected) as 100Mbps.

With the PHYLINK code the above fragment is pretty much the same except for:

                        sfp = <&sfp0>;
                        phy-mode = "sgmii";
                        managed = "in-band-status";

Both (old and new) drivers are working fine on 1Gbps links with optics and 
copper SFPs.  With PHYLINK code (and in auto-negotiation mode) the link speed 
and duplex is properly detected as 100Mbps.  MAC and PCS also look correctly set 
up, but the device is still unable to receive or transmit packages.


Please let me know should you need more details.


thanks,
Petko

             reply	other threads:[~2019-11-27 14:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-27 13:54 Petko Manolov [this message]
2019-12-03  9:29 ` Altera TSE driver not working in 100mbps mode Petko Manolov
2020-09-16 21:32   ` David Bilsby
2020-09-17  6:42     ` Petko Manolov
     [not found]       ` <9f312748-1069-4a30-ba3f-d1de6d84e920@virgin.net>
2020-09-18 17:14         ` Petko Manolov
2020-09-30 20:43           ` David Bilsby
2020-09-30 23:59             ` Andrew Lunn
2020-10-01  6:42               ` Petko Manolov
2020-10-01  6:39             ` Petko Manolov
2020-10-01  8:29               ` David Laight

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191127135419.7r53qw6vtp747x62@p310 \
    --to=petkan@nucleusys.com \
    --cc=netdev@vger.kernel.org \
    --cc=thor.thayer@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).