From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A7C3C432C0 for ; Wed, 27 Nov 2019 18:44:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 153B0207DD for ; Wed, 27 Nov 2019 18:44:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nJ+P4iz7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727141AbfK0SoH (ORCPT ); Wed, 27 Nov 2019 13:44:07 -0500 Received: from mail-qt1-f196.google.com ([209.85.160.196]:38004 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726593AbfK0SoH (ORCPT ); Wed, 27 Nov 2019 13:44:07 -0500 Received: by mail-qt1-f196.google.com with SMTP id 14so26384272qtf.5; Wed, 27 Nov 2019 10:44:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=vLYRgEqQraqD/jRbKwCGJCTuqQIUu2eT37zrYdLloVI=; b=nJ+P4iz7K1/DdSVU64e3WR10Y5BWSkScNTlF35QpsGFfzfe2LkwADm77GfF23oEAzX ChXEdSxrkcPbEpZV0UtPYDPo17JK5jbcSgWwGOWN/Ql12Mfia2zKvweOig/ilUui4++G I9liubb+CgMfS5/zYVGGOGcBfDXx0MH8gqMnHIFGf304dcSD1MfcKFJFhY0iHOOTuamM 6PNP8l6nvSddiDmN0DRTYgTsEoeJJuDMSng3qASLI+1pyxGc/f4LVssZgxIdMaOLFnMV d9k1w+FifS7kDQJLf1IzBit0oURjWCMzV62pG93cMWI3g0TE+751jHOj/t9YeSrBtNMr NY3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=vLYRgEqQraqD/jRbKwCGJCTuqQIUu2eT37zrYdLloVI=; b=AAoim3ojxicW/WoXT2o+B8vJaryV3OUXY/dioj5ITru0Q+uup/W7EuEemE8UwntsiT S/spAXZfCgoneqymmvoxHzHoVQ4V3zne7VhsxAM8nvJSKxwICXMonfoTxE+MZhHLg0Xp zP94iur9J8URfBBox7NoSzTlBwEyvd6re68RpRuJL6ADZ29IgtPJN+jpLHrDfCje0Bhn rh8N0xNWllNPsPfd7rGGDQxJZQKO2scPCF6po9LcatV0dM3js0LspHeaTv6mY18hwkJF G4CWViiVZznNfjayOuj1/o3GnsSa2AgLeaMyBJYIzj0AqmdGXXHkvvjMoNEo7X1L5kiD ifAg== X-Gm-Message-State: APjAAAXTNwn77uA3c3/ox2ifUHF9vxkZLXpWhfnrDdO1sE6+IkGiuu1A 1xlnHVDbEzomo3hxa470GDi7n2JitId3zA== X-Google-Smtp-Source: APXvYqza+dZLDafmoYQJI1Bsn0z4hENX6OJOQ4Ofq+mRxeXSofLRpVnd2slRTjKLtZLI2mYQQ66nAQ== X-Received: by 2002:ac8:2a65:: with SMTP id l34mr8257242qtl.105.1574880246225; Wed, 27 Nov 2019 10:44:06 -0800 (PST) Received: from quaco.ghostprotocols.net ([190.15.121.82]) by smtp.gmail.com with ESMTPSA id x1sm7924206qtf.81.2019.11.27.10.44.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Nov 2019 10:44:06 -0800 (PST) From: Arnaldo Carvalho de Melo X-Google-Original-From: Arnaldo Carvalho de Melo Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id EDCAC40D3E; Wed, 27 Nov 2019 15:44:00 -0300 (-03) Date: Wed, 27 Nov 2019 15:44:00 -0300 To: Alexei Starovoitov Cc: Jiri Olsa , lkml , Network Development , bpf , Ingo Molnar , Namhyung Kim , Alexander Shishkin , Peter Zijlstra , Michael Petlan , Toke =?iso-8859-1?Q?H=F8iland-J=F8rgensen?= , Jesper Dangaard Brouer , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko Subject: Re: [PATCH 0/3] perf/bpftool: Allow to link libbpf dynamically Message-ID: <20191127184400.GA4063@kernel.org> References: <20191127094837.4045-1-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.12.1 (2019-06-15) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Em Wed, Nov 27, 2019 at 08:37:59AM -0800, Alexei Starovoitov escreveu: > On Wed, Nov 27, 2019 at 1:48 AM Jiri Olsa wrote: > > adding support to link bpftool with libbpf dynamically, > > and config change for perf. > > It's now possible to use: > > $ make -C tools/bpf/bpftool/ LIBBPF_DYNAMIC=1 > > which will detect libbpf devel package with needed version, > > and if found, link it with bpftool. > > It's possible to use arbitrary installed libbpf: > > $ make -C tools/bpf/bpftool/ LIBBPF_DYNAMIC=1 LIBBPF_DIR=/tmp/libbpf/ > > I based this change on top of Arnaldo's perf/core, because > > it contains libbpf feature detection code as dependency. > > It's now also synced with latest bpf-next, so Toke's change > > applies correctly. > I don't like it. > Especially Toke's patch to expose netlink as public and stable libbpf api. > bpftools needs to stay tightly coupled with libbpf (and statically > linked for that reason). > Otherwise libbpf will grow a ton of public api that would have to be stable > and will quickly become a burden. I can relate to that, tools/lib/perf/ is only now getting put in place because of these fears, hopefully the evsel/evlist/cpumap/etc abstractions there have been in use for a long time and will be not be a burden... :-) - Arnaldo