netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Richard Cochran <richardcochran@gmail.com>
To: Michael Walle <michael@walle.cc>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>
Subject: Re: phy timestamping "library"
Date: Thu, 28 Nov 2019 00:23:51 -0800	[thread overview]
Message-ID: <20191128082351.GA3705@localhost> (raw)
In-Reply-To: <a45cdb5be352ece0b724f7e03493c4ff@walle.cc>

On Tue, Nov 26, 2019 at 07:00:02PM +0100, Michael Walle wrote:
> So what I'd like to have in a seperate "library" is the following:
>  - skb queues handling
>  - rx timestamp pool handling
>  - rx timestamp timeout handling
>  - skb delivery to the network stack on either match or timeout

I would resist the temptation to turn this into a "library", unless
there is a clear benefit.

> Now I have the following problem: the original driver attaches more data
> to the timestamp, as is my driver; this data is used by the match
> function.

...

> But how can I give that memory to the lib in phyts_init() and how can
> phyts_init() populate its rx_pool_data. Or maybe I'm getting it all
> wrong and there is a better way ;)

Sounds like the re-factoring of a couple of lists into a "library" is
not worth the effort.  The differences in the matching logic will make
the "library" baroque.

I suggest not over-engineering your new driver.  In any case, it is
hard to say without seeing the patches.

Thanks,
Richard

      reply	other threads:[~2019-11-28  8:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-26 18:00 phy timestamping "library" Michael Walle
2019-11-28  8:23 ` Richard Cochran [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191128082351.GA3705@localhost \
    --to=richardcochran@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=michael@walle.cc \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).