netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net] net: phy: realtek: fix using paged operations with RTL8105e / RTL8208
@ 2019-12-01  9:51 Heiner Kallweit
  2019-12-01 21:16 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Heiner Kallweit @ 2019-12-01  9:51 UTC (permalink / raw)
  To: David Miller, Realtek linux nic maintainers, Andrew Lunn,
	Florian Fainelli
  Cc: netdev, jhdskag3

It was reported [0] that since the referenced commit a warning is
triggered in phylib that complains about paged operations being used
with a PHY driver that doesn't support this. The commit isn't wrong,
just for one chip version (RTL8105e) no dedicated PHY driver exists
yet. So add the missing PHY driver.

[0] https://bugzilla.kernel.org/show_bug.cgi?id=202103

Fixes: 3a129e3f9ac4 ("r8169: switch to phylib functions in more places")
Reported-by: jhdskag3 <jhdskag3@tutanota.com>
Tested-by: jhdskag3 <jhdskag3@tutanota.com>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 drivers/net/phy/realtek.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/net/phy/realtek.c b/drivers/net/phy/realtek.c
index 677c45985..476db5345 100644
--- a/drivers/net/phy/realtek.c
+++ b/drivers/net/phy/realtek.c
@@ -439,6 +439,15 @@ static struct phy_driver realtek_drvs[] = {
 		.resume		= genphy_resume,
 		.read_page	= rtl821x_read_page,
 		.write_page	= rtl821x_write_page,
+	}, {
+		PHY_ID_MATCH_MODEL(0x001cc880),
+		.name		= "RTL8208 Fast Ethernet",
+		.read_mmd	= genphy_read_mmd_unsupported,
+		.write_mmd	= genphy_write_mmd_unsupported,
+		.suspend	= genphy_suspend,
+		.resume		= genphy_resume,
+		.read_page	= rtl821x_read_page,
+		.write_page	= rtl821x_write_page,
 	}, {
 		PHY_ID_MATCH_EXACT(0x001cc910),
 		.name		= "RTL8211 Gigabit Ethernet",
-- 
2.24.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net] net: phy: realtek: fix using paged operations with RTL8105e / RTL8208
  2019-12-01  9:51 [PATCH net] net: phy: realtek: fix using paged operations with RTL8105e / RTL8208 Heiner Kallweit
@ 2019-12-01 21:16 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-12-01 21:16 UTC (permalink / raw)
  To: hkallweit1; +Cc: nic_swsd, andrew, f.fainelli, netdev, jhdskag3

From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Sun, 1 Dec 2019 10:51:47 +0100

> It was reported [0] that since the referenced commit a warning is
> triggered in phylib that complains about paged operations being used
> with a PHY driver that doesn't support this. The commit isn't wrong,
> just for one chip version (RTL8105e) no dedicated PHY driver exists
> yet. So add the missing PHY driver.
> 
> [0] https://bugzilla.kernel.org/show_bug.cgi?id=202103
> 
> Fixes: 3a129e3f9ac4 ("r8169: switch to phylib functions in more places")
> Reported-by: jhdskag3 <jhdskag3@tutanota.com>
> Tested-by: jhdskag3 <jhdskag3@tutanota.com>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

Applied.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-12-01 21:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-01  9:51 [PATCH net] net: phy: realtek: fix using paged operations with RTL8105e / RTL8208 Heiner Kallweit
2019-12-01 21:16 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).