From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FEA7C432C0 for ; Mon, 2 Dec 2019 21:04:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4EDAB206E1 for ; Mon, 2 Dec 2019 21:04:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727010AbfLBVE1 (ORCPT ); Mon, 2 Dec 2019 16:04:27 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:40538 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726970AbfLBVE1 (ORCPT ); Mon, 2 Dec 2019 16:04:27 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:1c3::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 1424414CEFF0F; Mon, 2 Dec 2019 13:04:26 -0800 (PST) Date: Mon, 02 Dec 2019 13:04:23 -0800 (PST) Message-Id: <20191202.130423.1014387604144365216.davem@davemloft.net> To: martinvarghesenokia@gmail.com Cc: netdev@vger.kernel.org, pshelar@ovn.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, martin.varghese@nokia.com Subject: Re: [PATCH v3 net] Fixed updating of ethertype in function skb_mpls_pop From: David Miller In-Reply-To: <1575263991-5915-1-git-send-email-martinvarghesenokia@gmail.com> References: <1575263991-5915-1-git-send-email-martinvarghesenokia@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 02 Dec 2019 13:04:26 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Martin Varghese Date: Mon, 2 Dec 2019 10:49:51 +0530 > From: Martin Varghese > > The skb_mpls_pop was not updating ethertype of an ethernet packet if the > packet was originally received from a non ARPHRD_ETHER device. > > In the below OVS data path flow, since the device corresponding to port 7 > is an l3 device (ARPHRD_NONE) the skb_mpls_pop function does not update > the ethertype of the packet even though the previous push_eth action had > added an ethernet header to the packet. > > recirc_id(0),in_port(7),eth_type(0x8847), > mpls(label=12/0xfffff,tc=0/0,ttl=0/0x0,bos=1/1), > actions:push_eth(src=00:00:00:00:00:00,dst=00:00:00:00:00:00), > pop_mpls(eth_type=0x800),4 > > Fixes: ed246cee09b9 ("net: core: move pop MPLS functionality from OvS to core helper") > Signed-off-by: Martin Varghese Applied and queued up for -stable, thanks.