From: Florian Westphal <fw@strlen.de>
To: Marco Oliverio <marco.oliverio@tanaza.com>
Cc: netfilter-devel@vger.kernel.org,
Rocco Folino <notifications@github.com>,
Florian Westphal <fw@strlen.de>, netdev <netdev@vger.kernel.org>
Subject: Re: forwarded bridged packets enqueuing is broken
Date: Mon, 2 Dec 2019 17:16:32 +0100 [thread overview]
Message-ID: <20191202161632.GO795@breakpoint.cc> (raw)
In-Reply-To: <87pnh6lxch.fsf@tanaza.com>
Marco Oliverio <marco.oliverio@tanaza.com> wrote:
> We cannot enqueue userspace bridged forwarded packets (neither in the
> forward chain nor in the postrouting one):
[..]
> AFAIU forwarded bridge packets have a null dst entry in the first
> place, as they don't enter the ip stack, so skb_dst_force() returns
> false. The very same commit suggested to check skb_dst() before
> skb_dst_force(), doing that indeed fix the issue for us:
>
> modified net/netfilter/nf_queue.c
> @@ -174,7 +174,7 @@ static int __nf_queue(struct sk_buff *skb, const struct nf_hook_state *state,
> goto err;
> }
>
> - if (!skb_dst_force(skb) && state->hook != NF_INET_PRE_ROUTING) {
> + if (skb_dst(skb) && !skb_dst_force(skb)) {
Looks fine to me, please submit this formally. Thanks!
prev parent reply other threads:[~2019-12-02 16:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-02 12:34 forwarded bridged packets enqueuing is broken Marco Oliverio
2019-12-02 16:16 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191202161632.GO795@breakpoint.cc \
--to=fw@strlen.de \
--cc=marco.oliverio@tanaza.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=notifications@github.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).