From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=Mw/Y=ZZ=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 2F4B1C432C3
	for <netdev@archiver.kernel.org>; Tue,  3 Dec 2019 19:22:39 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id E7F1120803
	for <netdev@archiver.kernel.org>; Tue,  3 Dec 2019 19:22:38 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=default; t=1575400959;
	bh=jMBy3l/Mv0hpws/w7vjalerNFCYSodutowrkOZkzH5c=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From;
	b=d1pRmmxkGzQS1B1CGxdjcDblTLA/WjZuePhQc3uZYCT3y1Zy6L9pUT0ayDRy/p4nN
	 hh1qLn1dvbHD40yYR3KlNYLGbIGtk8zfApHdMIZpDO4NUIWNJIWNKSP2TVPakREA87
	 C985DCakUIfMpV7WFAxJIiTngl0tbMnveWpEQDo0=
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727350AbfLCTWi (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Tue, 3 Dec 2019 14:22:38 -0500
Received: from mail.kernel.org ([198.145.29.99]:59682 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726932AbfLCTWh (ORCPT <rfc822;netdev@vger.kernel.org>);
        Tue, 3 Dec 2019 14:22:37 -0500
Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id C90B020640;
        Tue,  3 Dec 2019 19:22:36 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1575400957;
        bh=jMBy3l/Mv0hpws/w7vjalerNFCYSodutowrkOZkzH5c=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=e824hFU0DnLHwV30Z+dzSn5brd9jZWFvJ6OEen79eQ7XBH9EKsRBceGbErXsA4sfI
         2vVpG8qozQYgYYSmigXw1mUf4EbU7mQHKV7UsJeu+2ejjdR/Fze31jbTJOicOmPagT
         R3MS1wkqh+Ngjt1XoBaJqvHfBSzqCpwzNad/zuwA=
Date:   Tue, 3 Dec 2019 20:22:34 +0100
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Eric Dumazet <edumazet@google.com>
Cc:     "David S . Miller" <davem@davemloft.net>,
        netdev <netdev@vger.kernel.org>,
        Eric Dumazet <eric.dumazet@gmail.com>,
        Soheil Hassas Yeganeh <soheil@google.com>,
        Neal Cardwell <ncardwell@google.com>,
        Yuchung Cheng <ycheng@google.com>,
        Willem de Bruijn <willemb@google.com>
Subject: Re: [PATCH net] tcp: refactor tcp_retransmit_timer()
Message-ID: <20191203192234.GA2735936@kroah.com>
References: <20191203160552.31071-1-edumazet@google.com>
 <20191203191314.GA2734645@kroah.com>
 <CANn89i+LK6wHWStHTn3swgx8KDGQ2VMULk59JaRWi599=yx2pw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CANn89i+LK6wHWStHTn3swgx8KDGQ2VMULk59JaRWi599=yx2pw@mail.gmail.com>
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Tue, Dec 03, 2019 at 11:15:31AM -0800, Eric Dumazet wrote:
> On Tue, Dec 3, 2019 at 11:13 AM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > On Tue, Dec 03, 2019 at 08:05:52AM -0800, Eric Dumazet wrote:
> > > It appears linux-4.14 stable needs a backport of commit
> > > 88f8598d0a30 ("tcp: exit if nothing to retransmit on RTO timeout")
> > >
> > > Since tcp_rtx_queue_empty() is not in pre 4.15 kernels,
> > > let's refactor tcp_retransmit_timer() to only use tcp_rtx_queue_head()
> >
> > So does that mean that 4.19.y should get 88f8598d0a30 ("tcp: exit if
> > nothing to retransmit on RTO timeout") as-is?
> >
> 
> Yes indeed. All stable versions need it.

So 4.4.y and 4.9.y as well?

thanks,

greg k-h