From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DA1CC43603 for ; Thu, 5 Dec 2019 00:46:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1A9C42077B for ; Thu, 5 Dec 2019 00:46:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728533AbfLEAqO (ORCPT ); Wed, 4 Dec 2019 19:46:14 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:38292 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728011AbfLEAqN (ORCPT ); Wed, 4 Dec 2019 19:46:13 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:1c3::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 5C12B14F252A9; Wed, 4 Dec 2019 16:46:13 -0800 (PST) Date: Wed, 04 Dec 2019 16:46:12 -0800 (PST) Message-Id: <20191204.164612.1086273679730587962.davem@davemloft.net> To: snelson@pensando.io Cc: netdev@vger.kernel.org Subject: Re: [PATCH net] ionic: keep users rss hash across lif reset From: David Miller In-Reply-To: <20191203221734.70798-1-snelson@pensando.io> References: <20191203221734.70798-1-snelson@pensando.io> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 04 Dec 2019 16:46:13 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Shannon Nelson Date: Tue, 3 Dec 2019 14:17:34 -0800 > If the user has specified their own RSS hash key, don't > lose it across queue resets such as DOWN/UP, MTU change, > and number of channels change. This is fixed by moving > the key initialization to a little earlier in the lif > creation. > > Also, let's clean up the RSS config a little better on > the way down by setting it all to 0. > > Fixes: aa3198819bea ("ionic: Add RSS support") > Signed-off-by: Shannon Nelson Looks good, applied and queued up for -stable.