From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42BD2C43603 for ; Thu, 5 Dec 2019 01:12:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0D5E02053B for ; Thu, 5 Dec 2019 01:12:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728374AbfLEBME (ORCPT ); Wed, 4 Dec 2019 20:12:04 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:38564 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728100AbfLEBME (ORCPT ); Wed, 4 Dec 2019 20:12:04 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:1c3::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 1E62514F478FA; Wed, 4 Dec 2019 17:12:03 -0800 (PST) Date: Wed, 04 Dec 2019 17:12:02 -0800 (PST) Message-Id: <20191204.171202.946324250971280038.davem@davemloft.net> To: martinvarghesenokia@gmail.com Cc: netdev@vger.kernel.org, pshelar@ovn.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, martin.varghese@nokia.com Subject: Re: [PATCH net v2] net: Fixed updating of ethertype in skb_mpls_push() From: David Miller In-Reply-To: <1575505642-5626-1-git-send-email-martinvarghesenokia@gmail.com> References: <1575505642-5626-1-git-send-email-martinvarghesenokia@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 04 Dec 2019 17:12:03 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Martin Varghese Date: Thu, 5 Dec 2019 05:57:22 +0530 > From: Martin Varghese > > The skb_mpls_push was not updating ethertype of an ethernet packet if > the packet was originally received from a non ARPHRD_ETHER device. > > In the below OVS data path flow, since the device corresponding to > port 7 is an l3 device (ARPHRD_NONE) the skb_mpls_push function does > not update the ethertype of the packet even though the previous > push_eth action had added an ethernet header to the packet. > > recirc_id(0),in_port(7),eth_type(0x0800),ipv4(tos=0/0xfc,ttl=64,frag=no), > actions:push_eth(src=00:00:00:00:00:00,dst=00:00:00:00:00:00), > push_mpls(label=13,tc=0,ttl=64,bos=1,eth_type=0x8847),4 > > Fixes: 8822e270d697 ("net: core: move push MPLS functionality from OvS to core helper") > Signed-off-by: Martin Varghese > --- > Changes in v2: > Changed the subject line of patch. Applied and queued up for -stable, thanks.