From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FF5AC43603 for ; Wed, 4 Dec 2019 21:54:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D989E218AC for ; Wed, 4 Dec 2019 21:54:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="sNHngkNW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728229AbfLDVye (ORCPT ); Wed, 4 Dec 2019 16:54:34 -0500 Received: from mail-lf1-f67.google.com ([209.85.167.67]:41733 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728011AbfLDVya (ORCPT ); Wed, 4 Dec 2019 16:54:30 -0500 Received: by mail-lf1-f67.google.com with SMTP id m30so763720lfp.8 for ; Wed, 04 Dec 2019 13:54:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=VnhsCb+n6LgjC+6907Tb3B2Vl6EZOomyJ8tnp+TG/qc=; b=sNHngkNWV9ev/PowIGAz1Y8jFs9+YDnaFQVf/lco03gsiAcIQu1SbZnuJ3nQdVH7NO dqB3KDHH54WY/F8yOmZq7+XwbP3We2KsJhXSussbQI7WEkf2pJK9Dfv4VskpP8DP0xi9 RzokWdmqDSdtmSDaKdUMDRrvVxUrRdXp0gDizkbeHWwtxewzYwtw6aE5w/5hDpcO20SB 74FHt6IyhRWsBnQU/vFF7rWwOcznpjo77kfAOnzsGWoZ37J6sd+cfmNms7yTG4rlocFD N1REEnbp/vd+gBJEzbLLWJqAMdZTJZ+uw1Sg2M976u4gSv6gz4dbBj3zq1DgrdBZ4xt+ T2eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=VnhsCb+n6LgjC+6907Tb3B2Vl6EZOomyJ8tnp+TG/qc=; b=EgwgO5GGjc8X0E4H4X46s0uUsxWMouniqwKglr/6ZsXhPkr64frvZK4oHuurWswSgQ zu4XX4c+IB6dHjS+IhBaSBs8D4ZAhBcayJaSYX3PX+bH7Z18+9t+8w5sFIYVe2Oeyroi XFsiv0aluXSinyd1pwwrjxdELc5jmBVBA2xjjUfw2zfQ3Myf363DNU/D6x8zZ/oXfdal KU3+gx4J8LFnxLlqyRotvRY5PkLoQuQwXZwQdOXJAl8MxpwVKtg02nTZ78rt8EnHstnA CixaU2DBJgpAXLv3Fabvuo+YQ+nwYkZLZaPxq1RWUR6tl7lO8ZDdgbP12fL+Be6KxVcF rZsQ== X-Gm-Message-State: APjAAAU9VhpL13UvfeK1erAvOqrt7mu7U74S0D3txA5nZyMt3onP9k2S tMfZvwtMFdF8tw1g2FPXjPP5Gg== X-Google-Smtp-Source: APXvYqzPvrDymPjXRh9qruHs8tBDH3UgArE45+g66WgCMyK1u3JpllpAjDPD+rE9wYXI6GOY+loWbw== X-Received: by 2002:a19:c382:: with SMTP id t124mr3210526lff.124.1575496468486; Wed, 04 Dec 2019 13:54:28 -0800 (PST) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id e20sm3841379ljk.44.2019.12.04.13.54.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Dec 2019 13:54:28 -0800 (PST) Date: Wed, 4 Dec 2019 13:54:05 -0800 From: Jakub Kicinski To: Andrii Nakryiko Cc: Alexei Starovoitov , Toke =?UTF-8?B?SMO4?= =?UTF-8?B?aWxhbmQtSsO4cmdlbnNlbg==?= , Jiri Olsa , Arnaldo Carvalho de Melo , lkml , Networking , bpf , Ingo Molnar , Namhyung Kim , Alexander Shishkin , Peter Zijlstra , Michael Petlan , Jesper Dangaard Brouer , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , Quentin Monnet Subject: Re: [PATCHv4 0/6] perf/bpftool: Allow to link libbpf dynamically Message-ID: <20191204135405.3ffb9ad6@cakuba.netronome.com> In-Reply-To: References: <20191202131847.30837-1-jolsa@kernel.org> <87wobepgy0.fsf@toke.dk> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 4 Dec 2019 13:16:13 -0800, Andrii Nakryiko wrote: > I wonder what big advantage having bpftool in libbpf's Github repo > brings, actually? The reason we need libbpf on github is to allow > other projects like pahole to be able to use libbpf from submodule. > There is no such need for bpftool. > > I agree about preference to release them in sync, but that could be > easily done by releasing based on corresponding commits in github's > libbpf repo and kernel repo. bpftool doesn't have to physically live > next to libbpf on Github, does it? +1 > Calling github repo a "mirror" is incorrect. It's not a 1:1 copy of > files. We have a completely separate Makefile for libbpf, and we have > a bunch of stuff we had to re-implement to detach libbpf code from > kernel's non-UAPI headers. Doing this for bpftool as well seems like > just more maintenance. Keeping github's Makefile in sync with kernel's > Makefile (for libbpf) is PITA, I'd rather avoid similar pains for > bpftool without a really good reason. Agreed. Having libbpf on GH is definitely useful today, but one can hope a day will come when distroes will get up to speed on packaging libbpf, and perhaps we can retire it? Maybe 2, 3 years from now? Putting bpftool in the same boat is just more baggage.