netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ilias Apalodimas <ilias.apalodimas@linaro.org>
To: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: Jesper Dangaard Brouer <brouer@redhat.com>,
	Jonathan Lemon <jonathan.lemon@gmail.com>,
	netdev@vger.kernel.org, davem@davemloft.net, kernel-team@fb.com
Subject: Re: [net PATCH] xdp: obtain the mem_id mutex before trying to remove an entry.
Date: Wed, 4 Dec 2019 12:28:18 -0800	[thread overview]
Message-ID: <20191204202818.GA16934@Iliass-MacBook-Pro.local> (raw)
In-Reply-To: <64b28372-e203-92db-bc67-1c308334042f@ti.com>

On Wed, Dec 04, 2019 at 12:07:22PM +0200, Grygorii Strashko wrote:
> 
> 
> On 04/12/2019 10:32, Jesper Dangaard Brouer wrote:
> > On Tue, 3 Dec 2019 14:01:14 -0800
> > Jonathan Lemon <jonathan.lemon@gmail.com> wrote:
> > 
> > > A lockdep splat was observed when trying to remove an xdp memory
> > > model from the table since the mutex was obtained when trying to
> > > remove the entry, but not before the table walk started:
> > > 
> > > Fix the splat by obtaining the lock before starting the table walk.
> > > 
> > > Fixes: c3f812cea0d7 ("page_pool: do not release pool until inflight == 0.")
> > > Reported-by: Grygorii Strashko <grygorii.strashko@ti.com>
> > > Signed-off-by: Jonathan Lemon <jonathan.lemon@gmail.com>
> > 
> > Have you tested if this patch fix the problem reported by Grygorii?
> > 
> > Link: https://lore.kernel.org/netdev/c2de8927-7bca-612f-cdfd-e9112fee412a@ti.com
> > 
> > Grygorii can you test this?
> 
> Thanks.
> I do not see this trace any more and networking is working after if down/up
> 
> Tested-by: Grygorii Strashko <grygorii.strashko@ti.com>
> 
> 
> -- 
> Best regards,
> grygorii

Acked-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>

  parent reply	other threads:[~2019-12-04 20:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-03 22:01 [net PATCH] xdp: obtain the mem_id mutex before trying to remove an entry Jonathan Lemon
2019-12-04  8:32 ` Jesper Dangaard Brouer
2019-12-04 10:07   ` Grygorii Strashko
2019-12-04 11:38     ` Jesper Dangaard Brouer
2019-12-04 17:30       ` Jonathan Lemon
2019-12-04 20:28     ` Ilias Apalodimas [this message]
2019-12-05  0:36 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191204202818.GA16934@Iliass-MacBook-Pro.local \
    --to=ilias.apalodimas@linaro.org \
    --cc=brouer@redhat.com \
    --cc=davem@davemloft.net \
    --cc=grygorii.strashko@ti.com \
    --cc=jonathan.lemon@gmail.com \
    --cc=kernel-team@fb.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).