From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "David S. Miller" <davem@davemloft.net>,
Krzysztof Halasa <khc@pm.waw.pl>,
devel@driverdev.osuosl.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Eric Biggers <ebiggers@kernel.org>,
Andrew Hendry <andrew.hendry@gmail.com>,
linux-x25@vger.kernel.org,
Kevin Curtis <kevin.curtis@farsite.com>,
"R.J.Dunlop" <bob.dunlop@farsite.com>,
Zhao Qiang <qiang.zhao@nxp.com>,
syzbot+429c200ffc8772bfe070@syzkaller.appspotmail.com,
syzbot+eec0c87f31a7c3b66f7b@syzkaller.appspotmail.com
Subject: Re: [PATCH 4/4] [RFC] staging/net: move AF_X25 into drivers/staging
Date: Mon, 9 Dec 2019 16:41:01 +0100 [thread overview]
Message-ID: <20191209154101.GB1284708@kroah.com> (raw)
In-Reply-To: <20191209151256.2497534-4-arnd@arndb.de>
On Mon, Dec 09, 2019 at 04:12:56PM +0100, Arnd Bergmann wrote:
> syzbot keeps finding issues in the X.25 implementation that nobody is
> interested in fixing. Given that all the x25 patches of the past years
> that are not global cleanups tend to fix user-triggered oopses, is it
> time to just retire the subsystem?
>
> I looked a bit closer and found:
>
> - we used to support x25 hardware in linux, but with WAN_ROUTER
> removed in linux-3.9 and isdn4linux removed in 5.3, there is only hdlc,
> ethernet and the N_X25 tty ldisc left. Out of these, only HDLC_X25 made
> it beyond the experimental stage, so this is probably what everyone
> uses if there are users at all.
>
> - The most common hdlc hardware that people seem to be using are
> the "farsync" PCIe and USB adapters. Linux only has drivers for the
> older PCI devices from that series, but no hardware that works on
> modern systems.
>
> - The manufacturer still updates their own kernel drivers and provides
> support, but ships that with a fork or rewrite of the subsystem
> code now. Kevin Curtis is also listed as maintainer, but appears to
> have given up in 2013 after [1].
>
> - The most popular software implementation appears to be X25 over TCP
> (XOT), which is supported by Farsite and other out-of-tree stacks but
> never had an implementation in mainline.
>
> - Most other supported HDLC hardware that we supoprt is for the ISA or
> PCI buses. There are newer PCIe or USB devices, but those all require
> a custom device driver and often a custom subsystem, none of which got
> submitted for mainline inclusion. This includes hardware from Microgate
> (SyncLink), Comtrol (RocketPort Express) and Sealevel (SeaMAC).
>
> - The X.25 subsystem is listed as "odd fixes", but the last reply on
> the netdev mailing list from the maintainer was also in 2013[2].
>
> - The HDLC subsystem itself is listed as maintained by Krzysztof Halasa,
> and there were new drivers merged for SoC based devices as late as
> 2016 by Zhao Qiang: Freescale/NXP QUICC Engine and Maxim ds26522.
> There has not been much work on HDLC or drivers/net/wan recently,
> but both developers are still responsive on the mailing list and
> work on other parts of the kernel.
>
> Based on the above, I would conclude that X.25 can probably get moved
> to staging as keeping it in the kernel seems to do more harm than good,
> but HDLC below it should probably stay as there it seems there are still
> users of a small subset of the mainline drivers.
>
> Move all of X.25 into drivers/staging for now, with a projected removal
> date set for Linux-5.8.
>
> Cc: Eric Biggers <ebiggers@kernel.org>
> Cc: Andrew Hendry <andrew.hendry@gmail.com>
> Cc: linux-x25@vger.kernel.org
> Cc: Kevin Curtis <kevin.curtis@farsite.com>
> Cc: "R.J.Dunlop" <bob.dunlop@farsite.com>
> Cc: Zhao Qiang <qiang.zhao@nxp.com>
> Cc: Krzysztof Halasa <khc@pm.waw.pl>
> Reported-by: syzbot+429c200ffc8772bfe070@syzkaller.appspotmail.com
> Reported-by: syzbot+eec0c87f31a7c3b66f7b@syzkaller.appspotmail.com
> Link: https://syzkaller.appspot.com/bug?id=5b0ecf0386f56be7fe7210a14d0f62df765c0c39
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ----
>
> If anyone has different views or additional information, let us know.
>
> If you agree with the above, please Ack.
ACK!
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2019-12-09 15:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-09 15:12 [PATCH 1/4] [net-next] wan: remove stale Kconfig entries Arnd Bergmann
2019-12-09 15:12 ` [PATCH 2/4] [net-next] wan: remove sbni/granch driver Arnd Bergmann
2019-12-09 15:12 ` [PATCH 3/4] [net-next] wan: remove old frame relay driver Arnd Bergmann
2019-12-09 15:12 ` [PATCH 4/4] [RFC] staging/net: move AF_X25 into drivers/staging Arnd Bergmann
2019-12-09 15:41 ` Greg Kroah-Hartman [this message]
2019-12-09 18:29 ` David Miller
2019-12-09 19:26 ` Arnd Bergmann
2019-12-10 8:59 ` Martin Schiller
2019-12-10 13:51 ` Arnd Bergmann
2019-12-11 5:58 ` Martin Schiller
2019-12-11 7:10 ` Krzysztof Hałasa
2019-12-11 13:34 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191209154101.GB1284708@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andrew.hendry@gmail.com \
--cc=arnd@arndb.de \
--cc=bob.dunlop@farsite.com \
--cc=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=ebiggers@kernel.org \
--cc=kevin.curtis@farsite.com \
--cc=khc@pm.waw.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-x25@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=qiang.zhao@nxp.com \
--cc=syzbot+429c200ffc8772bfe070@syzkaller.appspotmail.com \
--cc=syzbot+eec0c87f31a7c3b66f7b@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).