From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28D21C2D0BF for ; Tue, 10 Dec 2019 19:44:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F394820652 for ; Tue, 10 Dec 2019 19:44:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="TfE54Bun" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726364AbfLJTos (ORCPT ); Tue, 10 Dec 2019 14:44:48 -0500 Received: from mail-oi1-f193.google.com ([209.85.167.193]:46895 "EHLO mail-oi1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726045AbfLJTor (ORCPT ); Tue, 10 Dec 2019 14:44:47 -0500 Received: by mail-oi1-f193.google.com with SMTP id a124so10919108oii.13 for ; Tue, 10 Dec 2019 11:44:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=cSRVrn8feD3OQNfvTx8m2swsMDSqby5uarB5TK91UvI=; b=TfE54BunmMZ1b3iHwS3zdd2nF63lFRI/pCVTLjpwgslmuAQYm9tSfwJ64F80uhEAfy FCBcJJQzdWhAa8pWm+obj3R+3Bi/h/dRUxN6Zani/IND6/zmEWJTBAKShqBxgHvpL/Ey V5F8KsycbdmKbs4kEZ/Fy4JPqBWFsp7eIfITaE3KVXWUdXZggvkmpkvWoaNJxb36Cmkk 7fYVLqoXO3ZOuIjysmXVzyy1/xzYHXEkEx5Hj36dUAnVpSyaVPxXputfCgMcQE7u7qau 8oYSe3v+LjdK5LV2xcqcyWYyynW1mC1x2UjgMqW7dssV9YAwzSjVuBv6byI1TVgKfB8Z drsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=cSRVrn8feD3OQNfvTx8m2swsMDSqby5uarB5TK91UvI=; b=KuUHLbofv9CWLhi8TegFL2doQQT1n1GUfY2sPSlyzwoj4IKDjMvgW/eJWbQpAdhVzX 0QMJie0YVwa7i1yXz747PgFAdX6ehiARqIwTfq0Nzm2ezOn4RoFxhWbg1TN6gPS5ae07 ++d8iDq+5qMw3XflK04e0w3q19/jX5JRy/uD6M8iJaS40UF1wVCsZdnqsoMEIChizAjB DjqispI9ZfQyN7KQETcxKuJE8Ms4SB+hMfl4smtEh9Ly/5ukjpg47O3DX4ZSYd6EER5v KgZgVV+S2oswUky39XryuJ4Y9ozADVvwZGXPHWb9M3VjfvnMKdZLulAMfWT6BOxAVT5L Z81A== X-Gm-Message-State: APjAAAXNu0Z9j/HeYWjrP7cDO/1iYZ5QViwzjN0sYJx2cjz6Kq56lEd+ p9JUmrtVVxozyWkwr4Hv2VA1ZQ== X-Google-Smtp-Source: APXvYqwqLm3iUij9wnL5yjOiQjWRrFFcsrbgFfyLXAjsmPxxqdUW/3jZd2xBO2Ce9dHG6tt5zHqrDQ== X-Received: by 2002:aca:481:: with SMTP id 123mr524185oie.110.1576007086696; Tue, 10 Dec 2019 11:44:46 -0800 (PST) Received: from ziepe.ca ([217.140.111.136]) by smtp.gmail.com with ESMTPSA id j130sm1727504oia.34.2019.12.10.11.44.45 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 10 Dec 2019 11:44:45 -0800 (PST) Received: from jgg by LT-JGG-7470.mtl.com with local (Exim 4.90_1) (envelope-from ) id 1ielR7-000028-0A; Tue, 10 Dec 2019 15:44:45 -0400 Date: Tue, 10 Dec 2019 15:44:44 -0400 From: Jason Gunthorpe To: Jeff Kirsher Cc: davem@davemloft.net, gregkh@linuxfoundation.org, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com, parav@mellanox.com Subject: Re: [net-next v3 00/20][pull request] Intel Wired LAN Driver Updates 2019-12-09 Message-ID: <20191210194444.GH46@ziepe.ca> References: <20191209224935.1780117-1-jeffrey.t.kirsher@intel.com> <20191210172233.GA46@ziepe.ca> <324a6a4c7553cea5225b6f94ff224e155a252b36.camel@intel.com> <20191210182543.GE46@ziepe.ca> <20191210191125.GG46@ziepe.ca> <46ed855e75f9eda89118bfad9c6f7b16dd372c71.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <46ed855e75f9eda89118bfad9c6f7b16dd372c71.camel@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Dec 10, 2019 at 11:23:32AM -0800, Jeff Kirsher wrote: > > I also do not want a headache with conflicts to a huge rdma driver in > > net, so you cannot send it to -net. > > Agreed, I do not want to cause you or David Miller any headaches. It was > not clear on what additional changes the RDMA team would have once their > driver got upstream. It isn't about your changes. We often do tree-wide change the RDMA APIs toward the driver. For instance Leon's work to add restracks and to move allocations out of drivers. If any driver is out of the rdma.git tree then this is all broken for us. > > Mellanox uses a shared branch approach now, it is working well but > > requires discipline to execute. > > Wouldn't a shared branch cause issues for either you or David Miller to > pull from, since it has changes from the RDMA and net-next tree's? The shared tree approach requires discipline and bunch of special considerations go into constructing it and organizing patches to make it work. When done properly there are no issues. > > You can also send your changes to net, wait a cycle then send the rdma > > changes. IIRC one of the other drivers is working this way. > > This sounds like the best option currently, since there is still a lot of > work being done in the ice driver. Since Greg wanted to see driver > examples, using the virtual bus, I can send the RDMA driver patches as RFC > in future submissions. This way, we can make sure the implementation is > acceptable and will be ready for submission, once the virtual bus and LAN > driver changes are accepted. OK Jason