From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30E6EC43603 for ; Tue, 10 Dec 2019 21:46:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E5D1020836 for ; Tue, 10 Dec 2019 21:46:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576014410; bh=mUD4W3Tq67ujXQHClMBqvBDuxNP3dbUk+hPXASdErHY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=caKO3aBlsXv5X2M41WPnT/450Eq0U1EV9k/f4dWJzXGfRCRCv4oAW21yxNys6qt+O Hm7Bho5jWyamwMCBqi1ArK2+fxQ1JBVApJ4RvEMPxt3h3ewSYefKU3DhJ+csLcAOO5 Hhl4FTG0dmSCOqYkhw/WzERLXCmDELv/Kg/G0yG8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729731AbfLJVqq (ORCPT ); Tue, 10 Dec 2019 16:46:46 -0500 Received: from mail.kernel.org ([198.145.29.99]:36228 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728974AbfLJVch (ORCPT ); Tue, 10 Dec 2019 16:32:37 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9DAA6206D5; Tue, 10 Dec 2019 21:32:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576013556; bh=mUD4W3Tq67ujXQHClMBqvBDuxNP3dbUk+hPXASdErHY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=n8Wgi46xjBPhEKggpX6tHL4Efa1R8ZpY9iw+NxU1xRbncKCL0QF1Jvhl15pOx4Qn/ KLZ0Q//UIgqoovUZzXCdnfHBNEc9D+vlYJ9LTKfUvqr0DQ1DwwJJV0345f+x1xm2cn ghbC95r0o+y8buIXpliIcMixVaHjIiYBRVXXiI+0= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Allen Pais , Kalle Valo , Sasha Levin , libertas-dev@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 012/177] libertas: fix a potential NULL pointer dereference Date: Tue, 10 Dec 2019 16:29:36 -0500 Message-Id: <20191210213221.11921-12-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191210213221.11921-1-sashal@kernel.org> References: <20191210213221.11921-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Allen Pais [ Upstream commit 7da413a18583baaf35dd4a8eb414fa410367d7f2 ] alloc_workqueue is not checked for errors and as a result, a potential NULL dereference could occur. Signed-off-by: Allen Pais Signed-off-by: Kalle Valo Signed-off-by: Sasha Levin --- drivers/net/wireless/marvell/libertas/if_sdio.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/wireless/marvell/libertas/if_sdio.c b/drivers/net/wireless/marvell/libertas/if_sdio.c index 39bf85d0ade0e..c7f8a29d2606b 100644 --- a/drivers/net/wireless/marvell/libertas/if_sdio.c +++ b/drivers/net/wireless/marvell/libertas/if_sdio.c @@ -1183,6 +1183,10 @@ static int if_sdio_probe(struct sdio_func *func, spin_lock_init(&card->lock); card->workqueue = alloc_workqueue("libertas_sdio", WQ_MEM_RECLAIM, 0); + if (unlikely(!card->workqueue)) { + ret = -ENOMEM; + goto err_queue; + } INIT_WORK(&card->packet_worker, if_sdio_host_to_card_worker); init_waitqueue_head(&card->pwron_waitq); @@ -1234,6 +1238,7 @@ static int if_sdio_probe(struct sdio_func *func, lbs_remove_card(priv); free: destroy_workqueue(card->workqueue); +err_queue: while (card->packets) { packet = card->packets; card->packets = card->packets->next; -- 2.20.1