From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFBADC00454 for ; Wed, 11 Dec 2019 13:17:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A5DDC214D8 for ; Wed, 11 Dec 2019 13:17:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="eUK89sLk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729475AbfLKNRj (ORCPT ); Wed, 11 Dec 2019 08:17:39 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:46096 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729442AbfLKNRi (ORCPT ); Wed, 11 Dec 2019 08:17:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576070257; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AX5fhWmUkcVTK2FGEAydksRsVVwg5DCyda4UF354+FM=; b=eUK89sLkwK4WEdYCOh7XW/Z+JcNRL6Az0F2MZG9jvMfovTfcJ/HF8+8XE+Xh7jHZ1eIuO2 7M+iOwXoUuBZZWPkLmsD3BRvGCaw6DFkkBg0BHdhNccRi55g3E9zyydJVGcP1MmGby68Wc 5/PncOVfERKJzoZeNfSvp4GlaEy19tc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-286-OSi8-b5bP9uGf_WTtpb2Qw-1; Wed, 11 Dec 2019 08:17:34 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4B441DB25; Wed, 11 Dec 2019 13:17:32 +0000 (UTC) Received: from carbon (ovpn-200-56.brq.redhat.com [10.40.200.56]) by smtp.corp.redhat.com (Postfix) with ESMTP id D1BDD100EBA4; Wed, 11 Dec 2019 13:17:25 +0000 (UTC) Date: Wed, 11 Dec 2019 14:17:23 +0100 From: Jesper Dangaard Brouer To: Arnd Bergmann Cc: brouer@redhat.com, "David S. Miller" , Ilias Apalodimas , Murali Karicheri , Grygorii Strashko , Alexei Starovoitov , Daniel Borkmann , Jakub Kicinski , Jesper Dangaard Brouer , John Fastabend , Andrew Lunn , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH 1/2] net: ethernet: ti: select PAGE_POOL for switchdev driver Message-ID: <20191211141723.2cb3d5e9@carbon> In-Reply-To: <20191211125643.1987157-1-arnd@arndb.de> References: <20191211125643.1987157-1-arnd@arndb.de> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: OSi8-b5bP9uGf_WTtpb2Qw-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 11 Dec 2019 13:56:09 +0100 Arnd Bergmann wrote: > The new driver misses a dependency: > > drivers/net/ethernet/ti/cpsw_new.o: In function `cpsw_rx_handler': > cpsw_new.c:(.text+0x259c): undefined reference to `__page_pool_put_page' > cpsw_new.c:(.text+0x25d0): undefined reference to `page_pool_alloc_pages' > drivers/net/ethernet/ti/cpsw_priv.o: In function `cpsw_fill_rx_channels': > cpsw_priv.c:(.text+0x22d8): undefined reference to `page_pool_alloc_pages' > cpsw_priv.c:(.text+0x2420): undefined reference to `__page_pool_put_page' > drivers/net/ethernet/ti/cpsw_priv.o: In function `cpsw_create_xdp_rxqs': > cpsw_priv.c:(.text+0x2624): undefined reference to `page_pool_create' > drivers/net/ethernet/ti/cpsw_priv.o: In function `cpsw_run_xdp': > cpsw_priv.c:(.text+0x2dc8): undefined reference to `__page_pool_put_page' > > Other drivers use 'select' for PAGE_POOL, so do the same here. > > Fixes: ed3525eda4c4 ("net: ethernet: ti: introduce cpsw switchdev based driver part 1 - dual-emac") > Signed-off-by: Arnd Bergmann Acked-by: Jesper Dangaard Brouer Thanks for fixing this. -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer