From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93E6BC2D0C6 for ; Wed, 11 Dec 2019 21:56:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6A52020637 for ; Wed, 11 Dec 2019 21:56:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726777AbfLKV4D (ORCPT ); Wed, 11 Dec 2019 16:56:03 -0500 Received: from correo.us.es ([193.147.175.20]:60272 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726368AbfLKV4D (ORCPT ); Wed, 11 Dec 2019 16:56:03 -0500 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 864AD3066C3 for ; Wed, 11 Dec 2019 22:56:00 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 78EB0DA70D for ; Wed, 11 Dec 2019 22:56:00 +0100 (CET) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 6E95ADA70A; Wed, 11 Dec 2019 22:56:00 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 7A8DFDA705; Wed, 11 Dec 2019 22:55:58 +0100 (CET) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Wed, 11 Dec 2019 22:55:58 +0100 (CET) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (sys.soleta.eu [212.170.55.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 55ACF4265A5A; Wed, 11 Dec 2019 22:55:58 +0100 (CET) Date: Wed, 11 Dec 2019 22:55:58 +0100 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Xin Long Cc: network dev , netfilter-devel@vger.kernel.org, davem@davemloft.net Subject: Re: [PATCH nf-next 6/7] netfilter: nft_tunnel: add the missing nla_nest_cancel() Message-ID: <20191211215558.saqx4aueqa6owezd@salvia> References: <40a34ac68b79886f755ec076cbf787ecf7fdc014.1575779993.git.lucien.xin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <40a34ac68b79886f755ec076cbf787ecf7fdc014.1575779993.git.lucien.xin@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, Dec 08, 2019 at 12:41:36PM +0800, Xin Long wrote: > When nla_put_xxx() fails under nla_nest_start_noflag(), > nla_nest_cancel() should be called, so that the skb can > be trimmed properly. > > Signed-off-by: Xin Long Acked-by: Pablo Neira Ayuso