From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Thomas Falcon <tlfalcon@linux.ibm.com>
Cc: netdev@vger.kernel.org, linuxppc-dev@ozlabs.org,
julietk@linux.vnet.ibm.com
Subject: Re: [PATCH net v2] net/ibmvnic: Fix typo in retry check
Date: Fri, 13 Dec 2019 17:27:47 -0800 [thread overview]
Message-ID: <20191213172747.5e5310c9@cakuba.netronome.com> (raw)
In-Reply-To: <1576078719-9604-1-git-send-email-tlfalcon@linux.ibm.com>
On Wed, 11 Dec 2019 09:38:39 -0600, Thomas Falcon wrote:
> This conditional is missing a bang, with the intent
> being to break when the retry count reaches zero.
>
> Fixes: 476d96ca9c ("ibmvnic: Bound waits for device queries")
> Suggested-by: Juliet Kim <julietk@linux.vnet.ibm.com>
> Signed-off-by: Thomas Falcon <tlfalcon@linux.ibm.com>
Ah damn, looks like this originates from my pseudo code.
I had to fix the fixes tag:
Commit: 847496ccfa22 ("net/ibmvnic: Fix typo in retry check")
Fixes tag: Fixes: 476d96ca9c ("ibmvnic: Bound waits for device queries")
Has these problem(s):
- SHA1 should be at least 12 digits long
Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
or later) just making sure it is not set (or set to "auto").
Applied to net, thanks!
> diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
> index efb0f10..2d84523 100644
> --- a/drivers/net/ethernet/ibm/ibmvnic.c
> +++ b/drivers/net/ethernet/ibm/ibmvnic.c
> @@ -184,7 +184,7 @@ static int ibmvnic_wait_for_completion(struct ibmvnic_adapter *adapter,
> netdev_err(netdev, "Device down!\n");
> return -ENODEV;
> }
> - if (retry--)
> + if (!retry--)
> break;
> if (wait_for_completion_timeout(comp_done, div_timeout))
> return 0;
next prev parent reply other threads:[~2019-12-14 1:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 15:38 [PATCH net v2] net/ibmvnic: Fix typo in retry check Thomas Falcon
2019-12-14 1:27 ` Jakub Kicinski [this message]
2019-12-16 15:57 ` Thomas Falcon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191213172747.5e5310c9@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=julietk@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=tlfalcon@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).