From: Stephen Hemminger <stephen@networkplumber.org>
To: Tariq Toukan <tariqt@mellanox.com>
Cc: David Ahern <dsahern@gmail.com>,
netdev@vger.kernel.org, ayal@mellanox.com, moshe@mellanox.com,
jiri@mellanox.com
Subject: Re: [PATCH iproute2 0/3] Devlink health reporter's issues
Date: Mon, 16 Dec 2019 20:53:51 -0800 [thread overview]
Message-ID: <20191216205351.1afb8c75@hermes.lan> (raw)
In-Reply-To: <20191211154536.5701-1-tariqt@mellanox.com>
On Wed, 11 Dec 2019 17:45:33 +0200
Tariq Toukan <tariqt@mellanox.com> wrote:
> Hi,
>
> This patchset by Aya fixes two issues: wrong time-stamp on a dump in
> devlink health reporter and messy display of non JSON output in devlink
> health diagnostics and dump.
>
> 1) Wrong time-stamp on a dump in devlink health reporter:
> This bug fix consist of 2 patches. First patch refactors the current
> implementation of helper function which displays the reporter's dump
> time-stamp and add the actual print to the function's body.
> The second patch introduces a new attribute which is the time-stamp in
> current time in nsec instead of jiffies. When the new attribute is
> present try and translate the time-stamp according to 'current time'.
>
> 2) Messy display of non-JSON output in devlink health diagnostics and dump:
> This patch mainly deals with dynamic object and array opening. The
> label is stored and only when the proceeding value arrives the name is
> printed with regards to the context.
>
> Series generated against the shared master/net-next head:
> 24bee3bf9752 tipc: add new commands to set TIPC AEAD key
>
> Regards,
> Tariq
>
> Aya Levin (3):
> devlink: Print health reporter's dump time-stamp in a helper function
> devlink: Add a new time-stamp format for health reporter's dump
> devlink: Fix fmsg nesting in non JSON output
>
> devlink/devlink.c | 153 +++++++++++++++++++++++++++++++++++-----------
> 1 file changed, 119 insertions(+), 34 deletions(-)
>
Applied, devlink really needs to get converted to same json
library as rest of iproute2.
next prev parent reply other threads:[~2019-12-17 4:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 15:45 [PATCH iproute2 0/3] Devlink health reporter's issues Tariq Toukan
2019-12-11 15:45 ` [PATCH iproute2 1/3] devlink: Print health reporter's dump time-stamp in a helper function Tariq Toukan
2019-12-11 15:45 ` [PATCH iproute2 2/3] devlink: Add a new time-stamp format for health reporter's dump Tariq Toukan
2019-12-11 15:45 ` [PATCH iproute2 3/3] devlink: Fix fmsg nesting in non JSON output Tariq Toukan
2019-12-17 4:53 ` Stephen Hemminger [this message]
2019-12-17 15:08 ` [PATCH iproute2 0/3] Devlink health reporter's issues David Ahern
2019-12-17 16:33 ` Stephen Hemminger
2019-12-18 14:53 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191216205351.1afb8c75@hermes.lan \
--to=stephen@networkplumber.org \
--cc=ayal@mellanox.com \
--cc=dsahern@gmail.com \
--cc=jiri@mellanox.com \
--cc=moshe@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=tariqt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).