From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC5E4C43603 for ; Tue, 17 Dec 2019 22:20:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A2A3A205ED for ; Tue, 17 Dec 2019 22:20:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726616AbfLQWUt (ORCPT ); Tue, 17 Dec 2019 17:20:49 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:43728 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725946AbfLQWUt (ORCPT ); Tue, 17 Dec 2019 17:20:49 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:1c3::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id CADB61476F2C2; Tue, 17 Dec 2019 14:20:48 -0800 (PST) Date: Tue, 17 Dec 2019 14:20:48 -0800 (PST) Message-Id: <20191217.142048.1420015947023495901.davem@davemloft.net> To: jouni.hogander@unikie.com Cc: netdev@vger.kernel.org, penguin-kernel@I-love.SAKURA.ne.jp, lukas.bulwahn@gmail.com Subject: Re: [PATCH] net-sysfs: Call dev_hold always in rx_queue_add_kobject From: David Miller In-Reply-To: <20191217084429.28001-1-jouni.hogander@unikie.com> References: <20191217084429.28001-1-jouni.hogander@unikie.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 17 Dec 2019 14:20:49 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: jouni.hogander@unikie.com Date: Tue, 17 Dec 2019 10:44:29 +0200 > From: Jouni Hogander > > Dev_hold has to be called always in rx_queue_add_kobject. > Otherwise usage count drops below 0 in case of failure in > kobject_init_and_add. > > Fixes: b8eb718348b8 ("net-sysfs: Fix reference count leak in rx|netdev_queue_add_kobject") > Reported-by: Hulk Robot > Cc: Tetsuo Handa > Cc: David Miller > Cc: Lukas Bulwahn > Signed-off-by: Jouni Hogander Why are you posting this again, the change is already in my tree?