From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED626C43603 for ; Wed, 18 Dec 2019 11:54:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C28D7206E0 for ; Wed, 18 Dec 2019 11:54:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZvyIrqbl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726994AbfLRLyK (ORCPT ); Wed, 18 Dec 2019 06:54:10 -0500 Received: from mail-pg1-f196.google.com ([209.85.215.196]:39240 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726718AbfLRLyJ (ORCPT ); Wed, 18 Dec 2019 06:54:09 -0500 Received: by mail-pg1-f196.google.com with SMTP id b137so1156094pga.6 for ; Wed, 18 Dec 2019 03:54:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+rHj5u3iMCCxJRY2ucHo6msf9NxCYuFCALQA7T/CkCg=; b=ZvyIrqblWXWx61afEjzZF8ODKbhdlcrxzY86JOibzhFH8en4Wm6KITby3ypWOYPkoT /Fu8dCiXmRqriMk+8eIQPs1jvcpUs6cs4Xroibt+tIIXjEKG3m8L1HAatAacbaXD2iQu Ou9Hq+Nqb5JegUc+UFLt8H6EedbADcHyl+AW0O+e9msZATJzsmzeZNH4k01ABetLtfy/ BknmdGXON8+uLHPY8i0SWvmlPlet6NMkyD2QufOanmPvDeLAh2UsRhL1E3plpjYUMCUm EFtT1TDz0Z+uyZ/5+Kp7iHVuOs7cDo0bS4hBuCS0Ys4QSyBtQKrlGny/YEiKTyjC5l6x wh3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+rHj5u3iMCCxJRY2ucHo6msf9NxCYuFCALQA7T/CkCg=; b=CPv5vvmtbStCitjyetkMsOzGDTtXVgMm+V9/IwpZ3ugpH/oJv6lspT9YZDUT04sA3R ZgdRhyjsPPiqdR6wcnFnkIUFbnEPJnkDAWJqYJfyCK9Xjz2YUpFKmkjXwL7ThJefpPsN RL5t7dHnw8lUT/tl1yRK5d2HCWFsZMXQbFGnZgMXKZEQHYKSPc8rRHY2rppBfiZpMeOl uZew975lmfF30ZhYf9Bcfw7LJ/KbcdY8EZXvGYjlNdaBc7BQJf0bd5ZA1iwr+aL0K88j OjLDU1c++vrpuAobbm4aViALasN2TVKMh4rdkjOUCHYBlg6KYSijsX6BkdWgQ0u0tp/0 aAIA== X-Gm-Message-State: APjAAAU37U5N0tt9i0N9ZuJzRtKgv15PgdenCaLS6yCmXRDJa7Sn1Owf mR8RIUGX36dXEM1XwyW0dK9pBi6uz8E= X-Google-Smtp-Source: APXvYqz0Lfbaadb4AlKpcUgtzW3su+7nObK4896gG9tKUaR2BeVqYn9n1DkSm+qrzPuA3o7jLhxHbQ== X-Received: by 2002:aa7:8ad9:: with SMTP id b25mr2589443pfd.70.1576670049050; Wed, 18 Dec 2019 03:54:09 -0800 (PST) Received: from dhcp-12-139.nay.redhat.com ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id x33sm2961067pga.86.2019.12.18.03.54.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Dec 2019 03:54:08 -0800 (PST) From: Hangbin Liu To: netdev@vger.kernel.org Cc: Julian Anastasov , Marcelo Ricardo Leitner , David Ahern , Eric Dumazet , Guillaume Nault , David Miller , Pablo Neira , Stephen Hemminger , Alexey Kodanev , Hangbin Liu Subject: [PATCH net-next 7/8] sit: do not confirm neighbor when do pmtu update Date: Wed, 18 Dec 2019 19:53:12 +0800 Message-Id: <20191218115313.19352-8-liuhangbin@gmail.com> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20191218115313.19352-1-liuhangbin@gmail.com> References: <20191203021137.26809-1-liuhangbin@gmail.com> <20191218115313.19352-1-liuhangbin@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org When do IPv6 tunnel PMTU update and calls __ip6_rt_update_pmtu() in the end, we should not call dst_confirm_neigh() as there is no two-way communication. Signed-off-by: Hangbin Liu --- net/ipv6/sit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv6/sit.c b/net/ipv6/sit.c index b2ccbc473127..98954830c40b 100644 --- a/net/ipv6/sit.c +++ b/net/ipv6/sit.c @@ -944,7 +944,7 @@ static netdev_tx_t ipip6_tunnel_xmit(struct sk_buff *skb, } if (tunnel->parms.iph.daddr) - skb_dst_update_pmtu(skb, mtu); + skb_dst_update_pmtu_no_confirm(skb, mtu); if (skb->len > mtu && !skb_is_gso(skb)) { icmpv6_send(skb, ICMPV6_PKT_TOOBIG, 0, mtu); -- 2.19.2