From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CFC3C43603 for ; Thu, 19 Dec 2019 22:16:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 53AF6227BF for ; Thu, 19 Dec 2019 22:16:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727006AbfLSWQV (ORCPT ); Thu, 19 Dec 2019 17:16:21 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:43072 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726930AbfLSWQV (ORCPT ); Thu, 19 Dec 2019 17:16:21 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:1c3::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 47AA8153CA864; Thu, 19 Dec 2019 14:16:20 -0800 (PST) Date: Thu, 19 Dec 2019 14:16:19 -0800 (PST) Message-Id: <20191219.141619.1840874136750249908.davem@davemloft.net> To: stephen@networkplumber.org Cc: cforno12@linux.vnet.ibm.com, netdev@vger.kernel.org, mst@redhat.com, jasowang@redhat.com, haiyangz@microsoft.com, sthemmin@microsoft.com, sashal@kernel.org, tlfalcon@linux.ibm.com Subject: Re: [PATCH, net-next, v3, 0/2] net/ethtool: Introduce link_ksettings API for virtual network devices From: David Miller In-Reply-To: <20191219131156.21332555@hermes.lan> References: <20191219194057.4208-1-cforno12@linux.vnet.ibm.com> <20191219131156.21332555@hermes.lan> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 19 Dec 2019 14:16:20 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Stephen Hemminger Date: Thu, 19 Dec 2019 13:11:56 -0800 > I don't think this makes sense for netvsc. The speed and duplex have no > meaning, why do you want to allow overriding it? If this is to try and make > some dashboard look good; then you aren't seeing the real speed which is > what only the host knows. Plus it does take into account the accelerated > networking path. Maybe that's the point, userspace has extraneous knowledge it might use to set it accurately. This helps for bonding/team etc. as well. I don't think there is any real harm in allowing to set this, and we've done this in the past I think.