From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFE21C2D0C1 for ; Thu, 19 Dec 2019 15:41:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9022A24672 for ; Thu, 19 Dec 2019 15:41:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726936AbfLSPll (ORCPT ); Thu, 19 Dec 2019 10:41:41 -0500 Received: from www62.your-server.de ([213.133.104.62]:48802 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726776AbfLSPlk (ORCPT ); Thu, 19 Dec 2019 10:41:40 -0500 Received: from [2001:1620:665:0:5795:5b0a:e5d5:5944] (helo=localhost) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1ihxvm-0008Re-07; Thu, 19 Dec 2019 16:41:38 +0100 Date: Thu, 19 Dec 2019 16:41:37 +0100 From: Daniel Borkmann To: Andrii Nakryiko Cc: bpf@vger.kernel.org, netdev@vger.kernel.org, ast@fb.com, andrii.nakryiko@gmail.com, kernel-team@fb.com Subject: Re: [PATCH bpf-next 2/3] libbpf/tools: add runqslower tool to libbpf Message-ID: <20191219154137.GB4198@linux-9.fritz.box> References: <20191219070659.424273-1-andriin@fb.com> <20191219070659.424273-3-andriin@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191219070659.424273-3-andriin@fb.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.101.4/25668/Thu Dec 19 10:55:58 2019) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Dec 18, 2019 at 11:06:57PM -0800, Andrii Nakryiko wrote: > Convert one of BCC tools (runqslower [0]) to BPF CO-RE + libbpf. It matches > its BCC-based counterpart 1-to-1, supporting all the same parameters and > functionality. > > runqslower tool utilizes BPF skeleton, auto-generated from BPF object file, > as well as memory-mapped interface to global (read-only, in this case) data. > Its makefile also ensures auto-generation of "relocatable" vmlinux.h, which is > necessary for BTF-typed raw tracepoints with direct memory access. > > [0] https://github.com/iovisor/bcc/blob/11bf5d02c895df9646c117c713082eb192825293/tools/runqslower.py > > Signed-off-by: Andrii Nakryiko > --- > tools/lib/bpf/tools/runqslower/.gitignore | 2 + > tools/lib/bpf/tools/runqslower/Makefile | 60 ++++++ > .../lib/bpf/tools/runqslower/runqslower.bpf.c | 101 ++++++++++ > tools/lib/bpf/tools/runqslower/runqslower.c | 187 ++++++++++++++++++ > tools/lib/bpf/tools/runqslower/runqslower.h | 13 ++ tools/lib/bpf/tools/ is rather weird, please add to tools/bpf/ which is the more appropriate place we have for small tools. Could also live directly in there, e.g. tools/bpf/runqslower.{c,h,bpf.c} and then built/run from selftests, but under libbpf directly is too odd. Thanks, Daniel