From: Guillaume Nault <gnault@redhat.com>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: netdev@vger.kernel.org, Julian Anastasov <ja@ssi.bg>,
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
David Ahern <dsahern@gmail.com>,
Eric Dumazet <edumazet@google.com>,
David Miller <davem@davemloft.net>,
Pablo Neira <pablo@netfilter.org>,
Stephen Hemminger <stephen@networkplumber.org>,
Alexey Kodanev <alexey.kodanev@oracle.com>
Subject: Re: [PATCH net-next 8/8] net/dst: do not confirm neighbor for vxlan and geneve pmtu update
Date: Thu, 19 Dec 2019 18:49:35 +0100 [thread overview]
Message-ID: <20191219174935.GB14566@linux.home> (raw)
In-Reply-To: <20191218115313.19352-9-liuhangbin@gmail.com>
On Wed, Dec 18, 2019 at 07:53:13PM +0800, Hangbin Liu wrote:
> When do IPv6 tunnel PMTU update and calls __ip6_rt_update_pmtu() in the end,
> we should not call dst_confirm_neigh() as there is no two-way communication.
>
> So disable the neigh confirm for vxlan and geneve pmtu update.
>
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
> ---
> include/net/dst.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/net/dst.h b/include/net/dst.h
> index 208e7c0c89d8..626cf614ad86 100644
> --- a/include/net/dst.h
> +++ b/include/net/dst.h
> @@ -535,7 +535,7 @@ static inline void skb_tunnel_check_pmtu(struct sk_buff *skb,
> u32 encap_mtu = dst_mtu(encap_dst);
>
> if (skb->len > encap_mtu - headroom)
> - skb_dst_update_pmtu(skb, encap_mtu - headroom);
> + skb_dst_update_pmtu_no_confirm(skb, encap_mtu - headroom);
> }
>
Fixes: a93bf0ff4490 ("vxlan: update skb dst pmtu on tx path")
Fixes: 52a589d51f10 ("geneve: update skb dst pmtu on tx path")
next prev parent reply other threads:[~2019-12-19 17:49 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-22 6:19 [PATCH net] ipv6/route: only update neigh confirm time if pmtu changed Hangbin Liu
2019-11-22 18:04 ` David Miller
2019-11-26 9:17 ` Hangbin Liu
2019-12-03 2:11 ` [PATCHv2 net] ipv6/route: should not update neigh confirm time during PMTU update Hangbin Liu
2019-12-03 2:47 ` David Miller
2019-12-03 10:15 ` Hangbin Liu
2019-12-03 10:25 ` Hangbin Liu
2019-12-03 19:58 ` David Miller
2019-12-10 3:36 ` Hangbin Liu
2019-12-10 17:00 ` Guillaume Nault
2019-12-18 11:53 ` [PATCH net-next 0/8] disable neigh update for tunnels during pmtu update Hangbin Liu
2019-12-18 11:53 ` [PATCH net-next 1/8] net: add bool confirm_neigh parameter for dst_ops.update_pmtu Hangbin Liu
2019-12-18 11:53 ` [PATCH net-next 2/8] ip6_gre: do not confirm neighbor when do pmtu update Hangbin Liu
2019-12-18 11:53 ` [PATCH net-next 3/8] gtp: " Hangbin Liu
2019-12-18 11:53 ` [PATCH net-next 4/8] net/dst: add new function skb_dst_update_pmtu_no_confirm Hangbin Liu
2019-12-18 11:53 ` [PATCH net-next 5/8] tunnel: do not confirm neighbor when do pmtu update Hangbin Liu
2019-12-19 17:47 ` Guillaume Nault
2019-12-20 2:36 ` Hangbin Liu
2019-12-18 11:53 ` [PATCH net-next 6/8] vti: " Hangbin Liu
2019-12-18 11:53 ` [PATCH net-next 7/8] sit: " Hangbin Liu
2019-12-18 11:53 ` [PATCH net-next 8/8] net/dst: do not confirm neighbor for vxlan and geneve " Hangbin Liu
2019-12-19 17:49 ` Guillaume Nault [this message]
2019-12-18 12:01 ` [PATCH net-next 0/8] disable neigh update for tunnels during " Hangbin Liu
2019-12-19 17:57 ` Guillaume Nault
2019-12-20 2:48 ` Hangbin Liu
2019-12-19 17:53 ` Guillaume Nault
2019-12-20 3:25 ` [PATCHv4 net " Hangbin Liu
2019-12-20 3:25 ` [PATCHv4 net 1/8] net: add bool confirm_neigh parameter for dst_ops.update_pmtu Hangbin Liu
2019-12-20 3:25 ` [PATCHv4 net 2/8] ip6_gre: do not confirm neighbor when do pmtu update Hangbin Liu
2019-12-20 3:25 ` [PATCHv4 net 3/8] gtp: " Hangbin Liu
2019-12-21 18:35 ` Guillaume Nault
2019-12-20 3:25 ` [PATCHv4 net 4/8] net/dst: add new function skb_dst_update_pmtu_no_confirm Hangbin Liu
2019-12-20 3:25 ` [PATCHv4 net 5/8] tunnel: do not confirm neighbor when do pmtu update Hangbin Liu
2019-12-21 18:43 ` Guillaume Nault
2019-12-20 3:25 ` [PATCHv4 net 6/8] vti: " Hangbin Liu
2019-12-21 18:30 ` Guillaume Nault
2019-12-20 3:25 ` [PATCHv4 net 7/8] sit: " Hangbin Liu
2019-12-20 3:25 ` [PATCHv4 net 8/8] net/dst: do not confirm neighbor for vxlan and geneve " Hangbin Liu
2019-12-21 18:38 ` Guillaume Nault
2019-12-20 16:14 ` [PATCHv4 net 0/8] disable neigh update for tunnels during " David Ahern
2019-12-22 2:51 ` [PATCHv5 " Hangbin Liu
2019-12-22 2:51 ` [PATCHv5 net 1/8] net: add bool confirm_neigh parameter for dst_ops.update_pmtu Hangbin Liu
2019-12-22 2:51 ` [PATCHv5 net 2/8] ip6_gre: do not confirm neighbor when do pmtu update Hangbin Liu
2019-12-22 2:51 ` [PATCHv5 net 3/8] gtp: " Hangbin Liu
2019-12-22 2:51 ` [PATCHv5 net 4/8] net/dst: add new function skb_dst_update_pmtu_no_confirm Hangbin Liu
2019-12-22 2:51 ` [PATCHv5 net 5/8] tunnel: do not confirm neighbor when do pmtu update Hangbin Liu
2019-12-22 2:51 ` [PATCHv5 net 6/8] vti: " Hangbin Liu
2019-12-22 2:51 ` [PATCHv5 net 7/8] sit: " Hangbin Liu
2019-12-22 2:51 ` [PATCHv5 net 8/8] net/dst: do not confirm neighbor for vxlan and geneve " Hangbin Liu
2019-12-22 22:10 ` [PATCHv5 net 0/8] disable neigh update for tunnels during " Guillaume Nault
2019-12-25 6:30 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191219174935.GB14566@linux.home \
--to=gnault@redhat.com \
--cc=alexey.kodanev@oracle.com \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=edumazet@google.com \
--cc=ja@ssi.bg \
--cc=liuhangbin@gmail.com \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).