From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D791C2D0C0 for ; Thu, 26 Dec 2019 03:49:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5067A206A4 for ; Thu, 26 Dec 2019 03:49:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726933AbfLZDtc (ORCPT ); Wed, 25 Dec 2019 22:49:32 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:37324 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726741AbfLZDtc (ORCPT ); Wed, 25 Dec 2019 22:49:32 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:1c3::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id A3A5215413546; Wed, 25 Dec 2019 19:49:31 -0800 (PST) Date: Wed, 25 Dec 2019 19:49:29 -0800 (PST) Message-Id: <20191225.194929.1465672299217213413.davem@davemloft.net> To: dalias@libc.org Cc: AWilcox@Wilcox-Tech.com, netdev@vger.kernel.org, linux-api@vger.kernel.org, musl@lists.openwall.com Subject: Re: [musl] Re: [PATCH] uapi: Prevent redefinition of struct iphdr From: David Miller In-Reply-To: <20191226010515.GD30412@brightrain.aerifal.cx> References: <20191222060227.7089-1-AWilcox@Wilcox-Tech.com> <20191225.163411.1590483851343305623.davem@davemloft.net> <20191226010515.GD30412@brightrain.aerifal.cx> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 25 Dec 2019 19:49:31 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Rich Felker Date: Wed, 25 Dec 2019 20:05:15 -0500 > On Wed, Dec 25, 2019 at 04:34:11PM -0800, David Miller wrote: >> I find it really strange that this, therefore, only happens for musl >> and we haven't had thousands of reports of this conflict with glibc >> over the years. > > It's possible that there's software that's including just one of the > headers conditional on __GLIBC__, and including both otherwise, or > something like that. Arguably this should be considered unsupported > usage; there are plenty of headers where that doesn't work and > shouldn't be expected to. I don't buy that, this is waaaaaay too common a header to use. Please investigate.