From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4F1BC2D0C3 for ; Mon, 30 Dec 2019 20:36:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8A5B920718 for ; Mon, 30 Dec 2019 20:36:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="G6sDaIa4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727746AbfL3Ugp (ORCPT ); Mon, 30 Dec 2019 15:36:45 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:43844 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727667AbfL3Ugp (ORCPT ); Mon, 30 Dec 2019 15:36:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=SXdGQUakfHybtX0jGG9d+Xw/HkMyol+MPHYTh6dQ3U4=; b=G6sDaIa4Z25UB8aomFAcrsYCxZ sHFxTi0i4H9s4qWhRn4C48sxjLww49Qqy7d0sMS3bqs9wzaNysXFjyhJJ1HsaMmC5d2mVBuQrMqCY XMAh9tp2x8TJRQRtngzHnGf9Eu8UdH6/Xkq5/TXmMV21bzOFORXZO94hq7H1fSecWwj4=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1im1lw-0006Vp-L5; Mon, 30 Dec 2019 21:36:16 +0100 Date: Mon, 30 Dec 2019 21:36:16 +0100 From: Andrew Lunn To: Florian Fainelli Cc: Alexander Lobakin , "David S. Miller" , Edward Cree , Vivien Didelot , Hauke Mehrtens , Sean Wang , Matthias Brugger , Jiri Pirko , Eric Dumazet , Paolo Abeni , Jakub Kicinski , Taehee Yoo , Stephen Hemminger , Stanislav Fomichev , Daniel Borkmann , Song Liu , Matteo Croce , Jakub Sitnicki , Paul Blakey , Yoshiki Komachi , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH RFC net-next 05/19] net: dsa: tag_ar9331: add GRO callbacks Message-ID: <20191230203616.GA24733@lunn.ch> References: <20191230143028.27313-1-alobakin@dlink.ru> <20191230143028.27313-6-alobakin@dlink.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Dec 30, 2019 at 10:20:50AM -0800, Florian Fainelli wrote: > On 12/30/19 6:30 AM, Alexander Lobakin wrote: > > Add GRO callbacks to the AR9331 tagger so GRO layer can now process > > such frames. > > > > Signed-off-by: Alexander Lobakin > > This is a good example and we should probably build a tagger abstraction > that is much simpler to fill in callbacks for (although indirect > function calls may end-up killing performance with retpoline and > friends), but let's consider this idea. Hi Florian We really do need some numbers here. Does GRO really help? On an ARM or MIPS platform, i don't think retpoline is an issue? But x86 is, and we do have a few x86 boards with switches. Maybe we can do some macro magic instead of function pointers, if we can keep it all within one object file? Andrew