From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71B0FC282DD for ; Thu, 9 Jan 2020 00:04:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4E737206F0 for ; Thu, 9 Jan 2020 00:04:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727557AbgAIAEB (ORCPT ); Wed, 8 Jan 2020 19:04:01 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:50002 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726438AbgAIAEB (ORCPT ); Wed, 8 Jan 2020 19:04:01 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:1c3::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 60FE415371C47; Wed, 8 Jan 2020 16:04:00 -0800 (PST) Date: Wed, 08 Jan 2020 16:03:59 -0800 (PST) Message-Id: <20200108.160359.356749095676572714.davem@davemloft.net> To: dan.carpenter@oracle.com Cc: mkubecek@suse.cz, f.fainelli@gmail.com, andrew@lunn.ch, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH net-next] ethtool: fix ->reply_size() error handling From: David Miller In-Reply-To: <20200108054125.feeckqg6xhab3wam@kili.mountain> References: <20200108054125.feeckqg6xhab3wam@kili.mountain> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 08 Jan 2020 16:04:00 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Dan Carpenter Date: Wed, 8 Jan 2020 08:41:25 +0300 > The "ret < 0" comparison is never true because "ret" is still zero. > > Fixes: 728480f12442 ("ethtool: default handlers for GET requests") > Signed-off-by: Dan Carpenter Applied.