From: David Miller <davem@davemloft.net>
To: ms@dev.tdt.de
Cc: arnd@arndb.de, andrew.hendry@gmail.com, edumazet@google.com,
gregkh@linuxfoundation.org, tglx@linutronix.de,
linux-x25@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com,
syzbot+429c200ffc8772bfe070@syzkaller.appspotmail.com,
syzbot+eec0c87f31a7c3b66f7b@syzkaller.appspotmail.com
Subject: Re: [PATCH] net/x25: fix nonblocking connect
Date: Thu, 09 Jan 2020 18:40:08 -0800 (PST) [thread overview]
Message-ID: <20200109.184008.1039668214219996565.davem@davemloft.net> (raw)
In-Reply-To: <20200109063114.23195-1-ms@dev.tdt.de>
From: Martin Schiller <ms@dev.tdt.de>
Date: Thu, 9 Jan 2020 07:31:14 +0100
> This patch fixes 2 issues in x25_connect():
>
> 1. It makes absolutely no sense to reset the neighbour and the
> connection state after a (successful) nonblocking call of x25_connect.
> This prevents any connection from being established, since the response
> (call accept) cannot be processed.
>
> 2. Any further calls to x25_connect() while a call is pending should
> simply return, instead of creating new Call Request (on different
> logical channels).
>
> This patch should also fix the "KASAN: null-ptr-deref Write in
> x25_connect" and "BUG: unable to handle kernel NULL pointer dereference
> in x25_connect" bugs reported by syzbot.
>
> Signed-off-by: Martin Schiller <ms@dev.tdt.de>
> Reported-by: syzbot+429c200ffc8772bfe070@syzkaller.appspotmail.com
> Reported-by: syzbot+eec0c87f31a7c3b66f7b@syzkaller.appspotmail.com
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2020-01-10 2:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-06 9:31 KASAN: null-ptr-deref Write in x25_connect syzbot
2019-12-06 12:41 ` Arnd Bergmann
2020-01-09 6:31 ` [PATCH] net/x25: fix nonblocking connect Martin Schiller
2020-01-10 2:40 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200109.184008.1039668214219996565.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew.hendry@gmail.com \
--cc=arnd@arndb.de \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-x25@vger.kernel.org \
--cc=ms@dev.tdt.de \
--cc=netdev@vger.kernel.org \
--cc=syzbot+429c200ffc8772bfe070@syzkaller.appspotmail.com \
--cc=syzbot+eec0c87f31a7c3b66f7b@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).