From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B835EC33CA3 for ; Fri, 10 Jan 2020 15:51:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8A8712080D for ; Fri, 10 Jan 2020 15:51:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="N7d77Zlz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728356AbgAJPvi (ORCPT ); Fri, 10 Jan 2020 10:51:38 -0500 Received: from mail-pf1-f194.google.com ([209.85.210.194]:36975 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728245AbgAJPvi (ORCPT ); Fri, 10 Jan 2020 10:51:38 -0500 Received: by mail-pf1-f194.google.com with SMTP id p14so1331215pfn.4 for ; Fri, 10 Jan 2020 07:51:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=c9yn885qD54fB5dDn+OfSRgsgfTlFfhcqDGic7B3Aag=; b=N7d77Zlz7JlJ1aEZ2kcsr+1isJ0PTKTKt2JzoypNpcuRniw3hbIu21z/XvrfDkKiKB Mqh8c03o7oFen4sFQi0LrOjojdOaYFz03ARWLZ/atMQS1jp46hnwrTr8bGPW+jrxHORj Msw3Cide5jPRSQ17ISIsmfjQ50Q3q9nPU1NNC0THx6s4K2GlHOdAgWECiNjlkmkt1Oxb c5QOwVJExL1sCA7KuJ7cydRmenfClTtZw7gOO4D/1NtB0XJgy+H+kF2WX8oKqCC2QwZm zpsdMqFV7/K4dZeX62HEK48WKNrOd7FD5KiSrd8yaECATzMQteALSjlpvu2g5VnFR5tP RWCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=c9yn885qD54fB5dDn+OfSRgsgfTlFfhcqDGic7B3Aag=; b=Oo05TugrFkysskVHXLqBBJnlKzM1TTxL2ofNhwTog1g4WJ6stVtRBaGKwqRrsWUf39 JgFiq53mDjTKUQF8dceEtuvrjWyna777Tq6RSX991jTMB2wAyprqv+D8p2GbYW584UUL O7zCCrkeaWlV0W6vzyimg9y+MRbmNpKkOOa5cCsKKGknj4nc0PHUqzM8L3wf4AsRmwnO pumd0e0VK6e+aMGiMuM9uK3/QSOuCQUBB6CIw+InngYorr/p16mHSBfFJEY+dGVk9Yif fI1TOMaWx4XTySWUNDmFtAePqVVip/YLMWDb65kRWiEUQRxztDGk2pDnW1GL80NMQyMl qJKA== X-Gm-Message-State: APjAAAXsyjceZS/eYKSSOgC6Y7HtcKlzsT4ouAE/RissE6IKwxIU8Bz2 X4ht2U1Q0U9kUzcQ0d/t+LHHNQ== X-Google-Smtp-Source: APXvYqyr7d+yr0ozi0RepBQKh4gi5iEX1Vm3TUIkcSoGrtjD9PKcQuhSpSAR/9rzQT0qsXD6E7V5ug== X-Received: by 2002:a63:4824:: with SMTP id v36mr5157093pga.343.1578671497048; Fri, 10 Jan 2020 07:51:37 -0800 (PST) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id b19sm3235904pjq.8.2020.01.10.07.51.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jan 2020 07:51:36 -0800 (PST) Date: Fri, 10 Jan 2020 07:50:56 -0800 From: Stephen Hemminger To: Niu Xilei Cc: davem@davemloft.net, tglx@linutronix.de, fw@strlen.de, peterz@infradead.org, pabeni@redhat.com, anshuman.khandual@arm.com, linyunsheng@huawei.com, bigeasy@linutronix.de, jonathan.lemon@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pktgen: create packet use IPv6 source address between src6_min and src6_max. Message-ID: <20200110075056.06df4c0c@hermes.lan> In-Reply-To: <20200110102842.13585-1-niu_xilei@163.com> References: <20200110102842.13585-1-niu_xilei@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 10 Jan 2020 18:28:42 +0800 Niu Xilei wrote: > +/* Kernel not implement __int128's divide and modulo operator. Implement these > + * operation use shift-subtract division algorithm adpater from > + * https://chromium.googlesource.com/chromium/src/third_party/+/master/abseil-cpp/absl/numeric/int128.cc */ Some rewording of this comment is necessary to fix the English grammar. And Linux style is not to put comment closing on same line. Something like: /* The Linux kernel does not implement 128 bit divide and modulus operations. * Implement these operations using shift-subtract division algorithm * from Chrome. * https://chromium.googlesource.com/chromium/src/third_party/+/master/abseil-cpp/absl/numeric/int128.cc */ Also, the int128 code you referenced is Apache licensed (not GPL-v2 like kernel). For div128_u128 the function should be static to avoid name conflicts. The declarations need to be in reverse christmas tree order as well. It does seem a bit like overkill since doing source address over a 64 bit range should be more than enough for any test in this decade.