From: Peter Zijlstra <peterz@infradead.org>
To: "Singh, Balbir" <sblbir@amazon.com>
Cc: "Valentin, Eduardo" <eduval@amazon.com>,
"boris.ostrovsky@oracle.com" <boris.ostrovsky@oracle.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Agarwal, Anchal" <anchalag@amazon.com>,
"Woodhouse, David" <dwmw@amazon.co.uk>,
"vkuznets@redhat.com" <vkuznets@redhat.com>,
"sstabellini@kernel.org" <sstabellini@kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"Woodhouse@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com"
<Woodhouse@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"jgross@suse.com" <jgross@suse.com>,
"pavel@ucw.cz" <pavel@ucw.cz>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"x86@kernel.org" <x86@kernel.org>,
"roger.pau@citrix.com" <roger.pau@citrix.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
"mingo@redhat.com" <mingo@redhat.com>,
"Kamata, Munehisa" <kamatam@amazon.com>,
"bp@alien8.de" <bp@alien8.de>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"konrad.wilk@oracle.co" <konrad.wilk@oracle.co>,
"len.brown@intel.com" <len.brown@intel.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"fllinden@amaozn.com" <fllinden@amaozn.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [RFC PATCH V2 11/11] x86: tsc: avoid system instability in hibernation
Date: Mon, 13 Jan 2020 13:42:47 +0100 [thread overview]
Message-ID: <20200113124247.GG2827@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <857b42b2e86b2ae09a23f488daada3b1b2836116.camel@amazon.com>
On Mon, Jan 13, 2020 at 11:43:18AM +0000, Singh, Balbir wrote:
> For your original comment, just wanted to clarify the following:
>
> 1. After hibernation, the machine can be resumed on a different but compatible
> host (these are VM images hibernated)
> 2. This means the clock between host1 and host2 can/will be different
>
> In your comments are you making the assumption that the host(s) is/are the
> same? Just checking the assumptions being made and being on the same page with
> them.
I would expect this to be the same problem we have as regular suspend,
after power off the TSC will have been reset, so resume will have to
somehow bridge that gap. I've no idea if/how it does that.
I remember some BIOSes had crazy TSC ideas for suspend2ram, and we grew
tsc_restore_sched_clock_state() for it.
Playing crazy games like what you're doing just isn't it though.
next prev parent reply other threads:[~2020-01-13 12:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 23:45 [RFC PATCH V2 11/11] x86: tsc: avoid system instability in hibernation Anchal Agarwal
2020-01-08 10:50 ` Peter Zijlstra
2020-01-10 15:35 ` Eduardo Valentin
2020-01-13 10:16 ` Peter Zijlstra
2020-01-13 11:43 ` Singh, Balbir
2020-01-13 11:48 ` Rafael J. Wysocki
2020-01-13 12:42 ` Peter Zijlstra [this message]
2020-01-13 21:50 ` Rafael J. Wysocki
2020-01-13 23:30 ` Rafael J. Wysocki
2020-01-14 19:29 ` Anchal Agarwal
2020-01-22 20:07 ` Anchal Agarwal
2020-01-23 16:27 ` Boris Ostrovsky
2020-01-13 13:01 ` [Xen-devel] " Andrew Cooper
2020-01-13 13:54 ` David Woodhouse
2020-01-13 15:02 ` Singh, Balbir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200113124247.GG2827@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=Woodhouse@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com \
--cc=anchalag@amazon.com \
--cc=axboe@kernel.dk \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=davem@davemloft.net \
--cc=dwmw@amazon.co.uk \
--cc=eduval@amazon.com \
--cc=fllinden@amaozn.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=kamatam@amazon.com \
--cc=konrad.wilk@oracle.co \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=roger.pau@citrix.com \
--cc=sblbir@amazon.com \
--cc=sstabellini@kernel.org \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).