netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: davem@davemloft.net, johannes@sipsolutions.net, netdev@vger.kernel.org
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>
Subject: [PATCH net-next 0/8] skb_list_walk_safe refactoring for net/*'s skb_gso_segment usage
Date: Mon, 13 Jan 2020 18:42:25 -0500	[thread overview]
Message-ID: <20200113234233.33886-1-Jason@zx2c4.com> (raw)

This patchset adjusts all return values of skb_gso_segment in net/* to
use the new skb_list_walk_safe helper.

First we fix a minor bug in the helper macro that didn't come up in the
last patchset's uses. Then we adjust several cases throughout net/. The
xfrm changes were a bit hairy, but doable. Reading and thinking about
the code in mac80211 indicates a memory leak, which the commit
addresses. All the other cases were pretty trivial.

Jason A. Donenfeld (8):
  net: skbuff: disambiguate argument and member for skb_list_walk_safe
    helper
  net: udp: use skb_list_walk_safe helper for gso segments
  net: xfrm: use skb_list_walk_safe helper for gso segments
  net: openvswitch: use skb_list_walk_safe helper for gso segments
  net: sched: use skb_list_walk_safe helper for gso segments
  net: ipv4: use skb_list_walk_safe helper for gso segments
  net: netfilter: use skb_list_walk_safe helper for gso segments
  net: mac80211: use skb_list_walk_safe helper for gso segments

 include/linux/skbuff.h          |  6 +++---
 net/ipv4/ip_output.c            |  8 +++-----
 net/ipv4/udp.c                  |  3 +--
 net/ipv6/udp.c                  |  3 +--
 net/mac80211/tx.c               | 13 +++++--------
 net/netfilter/nfnetlink_queue.c |  8 +++-----
 net/openvswitch/datapath.c      | 11 ++++-------
 net/sched/sch_cake.c            |  4 +---
 net/sched/sch_tbf.c             |  4 +---
 net/xfrm/xfrm_device.c          | 15 ++++-----------
 net/xfrm/xfrm_output.c          |  9 +++------
 11 files changed, 29 insertions(+), 55 deletions(-)

-- 
2.24.1


             reply	other threads:[~2020-01-13 23:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-13 23:42 Jason A. Donenfeld [this message]
2020-01-13 23:42 ` [PATCH net-next 1/8] net: skbuff: disambiguate argument and member for skb_list_walk_safe helper Jason A. Donenfeld
2020-01-13 23:42 ` [PATCH net-next 2/8] net: udp: use skb_list_walk_safe helper for gso segments Jason A. Donenfeld
2020-01-13 23:42 ` [PATCH net-next 3/8] net: xfrm: " Jason A. Donenfeld
2020-01-13 23:42 ` [PATCH net-next 4/8] net: openvswitch: " Jason A. Donenfeld
2020-01-13 23:42 ` [PATCH net-next 5/8] net: sched: " Jason A. Donenfeld
2020-01-13 23:42 ` [PATCH net-next 6/8] net: ipv4: " Jason A. Donenfeld
2020-01-13 23:42 ` [PATCH net-next 7/8] net: netfilter: " Jason A. Donenfeld
2020-01-13 23:42 ` [PATCH net-next 8/8] net: mac80211: " Jason A. Donenfeld
2020-01-14 19:49 ` [PATCH net-next 0/8] skb_list_walk_safe refactoring for net/*'s skb_gso_segment usage David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200113234233.33886-1-Jason@zx2c4.com \
    --to=jason@zx2c4.com \
    --cc=davem@davemloft.net \
    --cc=johannes@sipsolutions.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).